From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4FBC433F5 for ; Mon, 23 May 2022 15:14:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237516AbiEWPOZ (ORCPT ); Mon, 23 May 2022 11:14:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237513AbiEWPOY (ORCPT ); Mon, 23 May 2022 11:14:24 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7532759B8B for ; Mon, 23 May 2022 08:14:23 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 091A75C01B1; Mon, 23 May 2022 11:14:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 23 May 2022 11:14:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653318861; x=1653405261; bh=LRgLiPwbnN PxI993DR7l88clkcTjZX/VfvbsptZQBdo=; b=TQZhEwHoGR1weHqIUxKyf04PLT muQm2jDU6QOSFxGmOVYCenTA4qLNGebu9yxPe6P1J42dY/mHIx7HGHim4kzLSx7g zO1SkHTBL/aeRl+jnyGqPlFfsQNidV4yjkdyFA105Upe+w0zEfNDA2dF1oNh/Wl/ LLXG10w87Uzd/pHJhE774j7Q28ZEu/q1awvAm/cmOOa/CJIx/oA3N0LFzlCpTbc2 cB3+4tBgwaMEr4yEOjkk6hnTo7lmV1FRwMnU6ltMcTk4AUIUsb1YXPJNmR0GiQd3 VCP1GCE47My/cB5IQkVAUMh+RRh010vPSsKMml+KxNePd/B06RfYlVa3OXIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653318861; x=1653405261; bh=LRgLiPwbnNPxI993DR7l88clkcTj ZX/VfvbsptZQBdo=; b=woRkJrQAKl9u+QeUuRf63p8lsVae5U8XWornbgNZoCFI TMeCfKYUGDvFY4dQu04i5iK99APkNW0adO5OjWna7ZM753cNCGsFAMJWzwPE3yEo Hvf5jTVWduZ3yhs2yHsHLnqQ9J8kjs+UB2Ek9wCZFvU6FEzRLRl6q6g8PXzJVg1G LzYm12khJFW1cFdht++FSWoJb803pnrTlzbhf7yNDm4IlcQugGFwPRDF00GkzkkQ JVzsj9pZvKbzqCBT8cTzbh4sKGoPNY3vySXM8gg7adVcYTLH53jMXv2z/PNIgQWR VFTSc2lUjoGuAA5h6+kW1+Xo3K7GaYY2eRdXfnEldA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjedugdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepifhrvghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheq necuggftrfgrthhtvghrnhepheegvdevvdeljeeugfdtudduhfekledtiefhveejkeejue fhtdeufefhgfehkeetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 May 2022 11:14:20 -0400 (EDT) Date: Mon, 23 May 2022 17:14:17 +0200 From: Greg KH To: Tan Tee Min Cc: stable@vger.kernel.org Subject: Re: [PATCH] net: stmmac: disable Split Header (SPH) for Intel platforms Message-ID: References: <20220523013910.3147844-1-tee.min.tan@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220523013910.3147844-1-tee.min.tan@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, May 23, 2022 at 09:39:10AM +0800, Tan Tee Min wrote: > commit 47f753c1108e287edb3e27fad8a7511a9d55578e upstream. > > Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation > of Split Header (SPH) feature is not supported for Ipv4 fragmented packet. > This SPH limitation will cause ping failure when the packets size exceed > the MTU size. For example, the issue happens once the basic ping packet > size is larger than the configured MTU size and the data is lost inside > the fragmented packet, replaced by zeros/corrupted values, and leads to > ping fail. > > So, disable the Split Header for Intel platforms. > > v2: Add fixes tag in commit message. > > Fixes: 67afd6d1cfdf("net: stmmac: Add Split Header support and enable it in XGMAC cores") > Cc: # 5.4.x > Suggested-by: Ong, Boon Leong > Signed-off-by: Mohammad Athari Bin Ismail > Signed-off-by: Wong Vee Khee > Signed-off-by: Tan Tee Min > Signed-off-by: David S. Miller > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 1 + > include/linux/stmmac.h | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) Now queued up, thanks. greg k-h