public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alex Elder <elder@linaro.org>
Cc: stable@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: ipa: compute proper aggregation limit
Date: Fri, 3 Jun 2022 16:30:46 +0200	[thread overview]
Message-ID: <YpobFgEcdslfDAq2@kroah.com> (raw)
In-Reply-To: <20220603123024.27609-1-elder@linaro.org>

On Fri, Jun 03, 2022 at 07:30:22AM -0500, Alex Elder wrote:
> commit c5794097b269f15961ed78f7f27b50e51766dec9 upstream.
> 
> The aggregation byte limit for an endpoint is currently computed
> based on the endpoint's receive buffer size.
> 
> However, some bytes at the front of each receive buffer are reserved
> on the assumption that--as with SKBs--it might be useful to insert
> data (such as headers) before what lands in the buffer.
> 
> The aggregation byte limit currently doesn't take into account that
> reserved space, and as a result, aggregation could require space
> past that which is available in the buffer.
> 
> Fix this by reducing the size used to compute the aggregation byte
> limit by the NET_SKB_PAD offset reserved for each receive buffer.
> 
> Cc: <stable@vger.kernel.org>    # 5.10.x
> Fixes: 84f9bd12d46db ("soc: qcom: ipa: IPA endpoints");
> Signed-off-by: Alex Elder <elder@linaro.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> The original commit doesn't cherry-pick cleanly to v5.10.119.  -Alex

All now queued up, thanks.

greg k-h

      parent reply	other threads:[~2022-06-03 14:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 12:30 [PATCH] net: ipa: compute proper aggregation limit Alex Elder
2022-06-03 12:30 ` Alex Elder
2022-06-03 12:30 ` Alex Elder
2022-06-03 14:30 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpobFgEcdslfDAq2@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=elder@linaro.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox