From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED44DC433EF for ; Fri, 3 Jun 2022 14:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242311AbiFCOax (ORCPT ); Fri, 3 Jun 2022 10:30:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230293AbiFCOaw (ORCPT ); Fri, 3 Jun 2022 10:30:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4F084C42B for ; Fri, 3 Jun 2022 07:30:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7B0ADB8234F for ; Fri, 3 Jun 2022 14:30:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEECCC385A9; Fri, 3 Jun 2022 14:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654266649; bh=eFIYrq5TsbcgqrwqxOtUoClZbSHWL+A/KBQr99NGMwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z/JQrn8+1JwV0epBQTnko6Dg/HS7Yss5OjmuUXYrimY+7X4qiQnMbdXpCPrZ648vk EJ004TD1sRUI6WesDuzu2qgKjx2tRbu61d0foSMwtzLpZuMoDhAJ8Y23m4j7lOvXLr Y6HFGKl1jGgt+lU/O/5nzCAYeJj/pKpbyGrgDU/0= Date: Fri, 3 Jun 2022 16:30:46 +0200 From: Greg KH To: Alex Elder Cc: stable@vger.kernel.org, "David S . Miller" Subject: Re: [PATCH] net: ipa: compute proper aggregation limit Message-ID: References: <20220603123024.27609-1-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603123024.27609-1-elder@linaro.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jun 03, 2022 at 07:30:22AM -0500, Alex Elder wrote: > commit c5794097b269f15961ed78f7f27b50e51766dec9 upstream. > > The aggregation byte limit for an endpoint is currently computed > based on the endpoint's receive buffer size. > > However, some bytes at the front of each receive buffer are reserved > on the assumption that--as with SKBs--it might be useful to insert > data (such as headers) before what lands in the buffer. > > The aggregation byte limit currently doesn't take into account that > reserved space, and as a result, aggregation could require space > past that which is available in the buffer. > > Fix this by reducing the size used to compute the aggregation byte > limit by the NET_SKB_PAD offset reserved for each receive buffer. > > Cc: # 5.10.x > Fixes: 84f9bd12d46db ("soc: qcom: ipa: IPA endpoints"); > Signed-off-by: Alex Elder > Signed-off-by: David S. Miller > --- > The original commit doesn't cherry-pick cleanly to v5.10.119. -Alex All now queued up, thanks. greg k-h