From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org, linux-block@vger.kernel.org,
Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 5.17-stable] block, loop: support partitions without scanning
Date: Mon, 13 Jun 2022 11:17:10 +0200 [thread overview]
Message-ID: <YqcAlj/r+vTOPLu6@kroah.com> (raw)
In-Reply-To: <20220609042432.1656938-1-hch@lst.de>
On Thu, Jun 09, 2022 at 06:24:32AM +0200, Christoph Hellwig wrote:
> Historically we did distinguish between a flag that surpressed partition
> scanning, and a combinations of the minors variable and another flag if
> any partitions were supported. This was generally confusing and doesn't
> make much sense, but some corner case uses of the loop driver actually
> do want to support manually added partitions on a device that does not
> actively scan for partitions. To make things worsee the loop driver
> also wants to dynamically toggle the scanning for partitions on a live
> gendisk, which makes the disk->flags updates non-atomic.
>
> Introduce a new GD_SUPPRESS_PART_SCAN bit in disk->state that disables
> just scanning for partitions, and toggle that instead of GENHD_FL_NO_PART
> in the loop driver.
>
> Fixes: 1ebe2e5f9d68 ("block: remove GENHD_FL_EXT_DEVT")
> Reported-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> Link: https://lore.kernel.org/r/20220527055806.1972352-1-hch@lst.de
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> (cherry picked from commit b9684a71fca793213378dd410cd11675d973eaa1)
Both queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-06-13 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 4:24 [PATCH 5.17-stable] block, loop: support partitions without scanning Christoph Hellwig
2022-06-13 9:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqcAlj/r+vTOPLu6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox