From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: stable@vger.kernel.org, Hsin-Yi Wang <hsinyi@chromium.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Will Deacon <will@kernel.org>, Sasha Levin <sashal@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH stable 4.9] fdt: Update CRC check for rng-seed
Date: Thu, 30 Jun 2022 15:21:06 +0200 [thread overview]
Message-ID: <Yr2jQvgVkyw6RWbB@kroah.com> (raw)
In-Reply-To: <20220628160111.2237376-1-f.fainelli@gmail.com>
On Tue, Jun 28, 2022 at 09:01:09AM -0700, Florian Fainelli wrote:
> From: Hsin-Yi Wang <hsinyi@chromium.org>
>
> commit dd753d961c4844a39f947be115b3d81e10376ee5 upstream
>
> Commit 428826f5358c ("fdt: add support for rng-seed") moves of_fdt_crc32
> from early_init_dt_verify() to early_init_dt_scan() since
> early_init_dt_scan_chosen() may modify fdt to erase rng-seed.
>
> However, arm and some other arch won't call early_init_dt_scan(), they
> call early_init_dt_verify() then early_init_dt_scan_nodes().
>
> Restore of_fdt_crc32 to early_init_dt_verify() then update it in
> early_init_dt_scan_chosen() if fdt if updated.
>
> Fixes: 428826f5358c ("fdt: add support for rng-seed")
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Will Deacon <will@kernel.org>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/of/fdt.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-06-30 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 16:01 [PATCH stable 4.9] fdt: Update CRC check for rng-seed Florian Fainelli
2022-06-28 16:01 ` [PATCH stable 4.14] " Florian Fainelli
2022-06-28 16:01 ` [PATCH stable 4.19] " Florian Fainelli
2022-06-30 13:21 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr2jQvgVkyw6RWbB@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hsinyi@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox