From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, stable@vger.kernel.org,
Jack Pham <quic_jackp@quicinc.com>
Subject: Re: [PATCH v1] usb: typec: add missing uevent when partner support PD
Date: Fri, 1 Jul 2022 08:08:37 +0200 [thread overview]
Message-ID: <Yr6PZaWNtHYfRfQf@kroah.com> (raw)
In-Reply-To: <1656637315-31229-1-git-send-email-quic_linyyuan@quicinc.com>
On Fri, Jul 01, 2022 at 09:01:55AM +0800, Linyu Yuan wrote:
> In typec_set_pwr_opmode(), if partner support PD, it need to send uevent.
I do not understand, you need to explain this better.
> Cc: stable@vger.kernel.org
What commit does this fix?
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> ---
> drivers/usb/typec/class.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index bbc46b1..3da94f712 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1851,6 +1851,7 @@ void typec_set_pwr_opmode(struct typec_port *port,
> partner->usb_pd = 1;
> sysfs_notify(&partner_dev->kobj, NULL,
> "supports_usb_power_delivery");
> + kobject_uevent(&partner_dev->kobj, KOBJ_CHANGE);
Why is this needed? Who will recieve this uevent? What will happen
when the uevent is sent? What userspace code requires this?
thanks,
greg k-h
prev parent reply other threads:[~2022-07-01 6:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 1:01 [PATCH v1] usb: typec: add missing uevent when partner support PD Linyu Yuan
2022-07-01 6:08 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr6PZaWNtHYfRfQf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_linyyuan@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox