From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 775DEC43334 for ; Thu, 23 Jun 2022 11:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbiFWLEt (ORCPT ); Thu, 23 Jun 2022 07:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbiFWLEp (ORCPT ); Thu, 23 Jun 2022 07:04:45 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED91C4B431; Thu, 23 Jun 2022 04:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655982284; x=1687518284; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uvRiXn0RqPUIUKiZwsBd2d49wVVCGlUjadwpX0J+dbo=; b=Jp+G15SqRh8yL6m561GCX/n6GhdPqTb7RGvVb92r34FqXZ5Lt/L2iGi3 j0dwYgQq6rvlZxnhYxkMowIk4h7kvk2eRCeZdrLuhLzABdDLnr2ZybjnO PuFcbW0gdwFjp9PD31wwip4+30ryxOaQuZOIlReWcwK+lZr/VQK92+2nk 3/0LBEby79s1tqc8b4C3y1m5PDPRmJzkNmoCuWNXT5GmuHv2GVJ6V0e0N Lee1iVqsCaOIdwgp0xHo+HflLhksaIsCosxsDsJ7+8v0WRpae/l3ys6jk 8iTdOwgLmbzG6NBrQmLUFePN6IRFYLRrjImnPjcJeX5ycFYmkcA6NwgyK Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="260505005" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="260505005" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 04:04:41 -0700 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="644684867" Received: from hazegrou-mobl.ger.corp.intel.com (HELO intel.com) ([10.251.216.121]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 04:04:35 -0700 Date: Thu, 23 Jun 2022 13:04:32 +0200 From: Andi Shyti To: Mauro Carvalho Chehab Cc: Chris Wilson , Fei Yang , =?utf-8?Q?Micha=C5=82?= Winiarski , Thomas Hellstrom , Thomas =?iso-8859-15?Q?Hellstr=F6m?= , Andi Shyti , Daniel Vetter , Daniele Ceraolo Spurio , Dave Airlie , David Airlie , Jani Nikula , Jason Ekstrand , John Harrison , Joonas Lahtinen , Lucas De Marchi , Maarten Lankhorst , Matt Roper , Matthew Auld , Matthew Brost , Ramalingam C , Rodrigo Vivi , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, mauro.chehab@linux.intel.com, stable@vger.kernel.org Subject: Re: [PATCH 1/6] drm/i915/gt: Ignore TLB invalidations on idle engines Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Mauro, On Wed, Jun 15, 2022 at 04:27:35PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > As an extension of the current skip TLB invalidations, > check if the device is powered down prior to any engine activity, > > as, on such cases, all the TLBs were already invalidated, so an > explicit TLB invalidation is not needed. > > This becomes more significant with GuC, as it can only do so when > the connection to the GuC is awake. > > Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") > > Signed-off-by: Chris Wilson > Cc: Fei Yang > Cc: Andi Shyti > Cc: stable@vger.kernel.org > Acked-by: Thomas Hellström > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Andi Shyti Andi