[stable] Improved TCP source port randomisation

[stable] Improved TCP source port randomisation

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

Please pick the following commits for 5.4 and 5.10 stable branches:

90564f36f1c3071d1e0c617cde342f9706e250be tcp: add some entropy in __inet_hash_connect()
506884b616e95714af173c47b89e7d1f5157c190 tcp: use different parts of the port_offset for index and offset
dabeb1baad260b2308477991f3006f4a1ac80d6d tcp: add small random increments to the source port
735ad25586cd381a3fdc8283e2d1cd4d65f0e9e7 tcp: dynamically allocate the perturb table used by source ports
ada9e93075c7d54a7fd28bae5429ed30ddd89bfa tcp: increase source port perturb table to 2^16
82f233b30b728249d1c374b77d722b2e4f55a631 tcp: drop the hash_32() part from the index calculation

I will send backports for older branches after this.

(All stable branches have the other 2 commits from this series; I'm not
sure why the whole series wasn't applied.)

Ben.

-- 
Ben Hutchings
Man invented language to satisfy his deep need to complain.
                                                          - Lily Tomlin

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [stable] Improved TCP source port randomisation

[Greg Kroah-Hartman]

On Wed, Jun 22, 2022 at 12:24:19AM +0200, Ben Hutchings wrote:
> Please pick the following commits for 5.4 and 5.10 stable branches:
> 
> 90564f36f1c3071d1e0c617cde342f9706e250be tcp: add some entropy in __inet_hash_connect()
> 506884b616e95714af173c47b89e7d1f5157c190 tcp: use different parts of the port_offset for index and offset
> dabeb1baad260b2308477991f3006f4a1ac80d6d tcp: add small random increments to the source port
> 735ad25586cd381a3fdc8283e2d1cd4d65f0e9e7 tcp: dynamically allocate the perturb table used by source ports
> ada9e93075c7d54a7fd28bae5429ed30ddd89bfa tcp: increase source port perturb table to 2^16
> 82f233b30b728249d1c374b77d722b2e4f55a631 tcp: drop the hash_32() part from the index calculation

All of these commit ids are not in Linus's tree, are you sure you got
them correct?

thanks,

greg k-h

Re: [stable] Improved TCP source port randomisation

[Greg Kroah-Hartman]

On Thu, Jun 23, 2022 at 05:58:33PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 22, 2022 at 12:24:19AM +0200, Ben Hutchings wrote:
> > Please pick the following commits for 5.4 and 5.10 stable branches:
> > 
> > 90564f36f1c3071d1e0c617cde342f9706e250be tcp: add some entropy in __inet_hash_connect()
> > 506884b616e95714af173c47b89e7d1f5157c190 tcp: use different parts of the port_offset for index and offset
> > dabeb1baad260b2308477991f3006f4a1ac80d6d tcp: add small random increments to the source port
> > 735ad25586cd381a3fdc8283e2d1cd4d65f0e9e7 tcp: dynamically allocate the perturb table used by source ports
> > ada9e93075c7d54a7fd28bae5429ed30ddd89bfa tcp: increase source port perturb table to 2^16
> > 82f233b30b728249d1c374b77d722b2e4f55a631 tcp: drop the hash_32() part from the index calculation
> 
> All of these commit ids are not in Linus's tree, are you sure you got
> them correct?

Ah, I can pick them from the mboxes you sent me in the other email...

Re: [stable] Improved TCP source port randomisation

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

On Thu, 2022-06-23 at 18:03 +0200, Greg Kroah-Hartman wrote:
> On Thu, Jun 23, 2022 at 05:58:33PM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jun 22, 2022 at 12:24:19AM +0200, Ben Hutchings wrote:
> > > Please pick the following commits for 5.4 and 5.10 stable branches:
> > > 
> > > 90564f36f1c3071d1e0c617cde342f9706e250be tcp: add some entropy in __inet_hash_connect()
> > > 506884b616e95714af173c47b89e7d1f5157c190 tcp: use different parts of the port_offset for index and offset
> > > dabeb1baad260b2308477991f3006f4a1ac80d6d tcp: add small random increments to the source port
> > > 735ad25586cd381a3fdc8283e2d1cd4d65f0e9e7 tcp: dynamically allocate the perturb table used by source ports
> > > ada9e93075c7d54a7fd28bae5429ed30ddd89bfa tcp: increase source port perturb table to 2^16
> > > 82f233b30b728249d1c374b77d722b2e4f55a631 tcp: drop the hash_32() part from the index calculation
> > 
> > All of these commit ids are not in Linus's tree, are you sure you got
> > them correct?
> 
> Ah, I can pick them from the mboxes you sent me in the other email...

Oops, sorry about that.

Ben.

-- 
Ben Hutchings
It's easier to fight for one's principles than to live up to them.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]