Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Coly Li <colyli@suse.de>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 1/1] bcache: memset on stack variables in bch_btree_check() and bch_sectors_dirty_init()
Date: Tue, 28 Jun 2022 11:10:01 +0200	[thread overview]
Message-ID: <YrrFaU+eWk37JtFd@kroah.com> (raw)
In-Reply-To: <20220628084933.8713-2-colyli@suse.de>

On Tue, Jun 28, 2022 at 04:49:33PM +0800, Coly Li wrote:
> The local variables check_state (in bch_btree_check()) and state (in
> bch_sectors_dirty_init()) should be fully filled by 0, because before
> allocating them on stack, they were dynamically allocated by kzalloc().
> 
> Signed-off-by: Coly Li <colyli@suse.de>
> Link: https://lore.kernel.org/r/20220527152818.27545-2-colyli@suse.de
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
>  drivers/md/bcache/btree.c     | 1 +
>  drivers/md/bcache/writeback.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 2362bb8ef6d1..e136d6edc1ed 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -2017,6 +2017,7 @@ int bch_btree_check(struct cache_set *c)
>  	if (c->root->level == 0)
>  		return 0;
>  
> +	memset(&check_state, 0, sizeof(struct btree_check_state));
>  	check_state.c = c;
>  	check_state.total_threads = bch_btree_chkthread_nr();
>  	check_state.key_idx = 0;
> diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
> index 75b71199800d..d138a2d73240 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -950,6 +950,7 @@ void bch_sectors_dirty_init(struct bcache_device *d)
>  		return;
>  	}
>  
> +	memset(&state, 0, sizeof(struct bch_dirty_init_state));
>  	state.c = c;
>  	state.d = d;
>  	state.total_threads = bch_btre_dirty_init_thread_nr();
> -- 
> 2.35.3
> 

What is the git commit id of this patch in Linus's tree?

thanks,

greg k-h

  reply	other threads:[~2022-06-28  9:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28  8:49 [PATCH 0/1] one bcache patch for stable tree Coly Li
2022-06-28  8:49 ` [PATCH 1/1] bcache: memset on stack variables in bch_btree_check() and bch_sectors_dirty_init() Coly Li
2022-06-28  9:10   ` Greg KH [this message]
2022-06-28  9:29     ` Coly Li
2022-06-30 11:18       ` Greg KH
2022-06-30 14:32         ` Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrrFaU+eWk37JtFd@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=colyli@suse.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox