From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D44CBC43334 for ; Tue, 5 Jul 2022 10:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232045AbiGEKq7 (ORCPT ); Tue, 5 Jul 2022 06:46:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231937AbiGEKq6 (ORCPT ); Tue, 5 Jul 2022 06:46:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B42BBD7; Tue, 5 Jul 2022 03:46:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 30AB2B815A5; Tue, 5 Jul 2022 10:46:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97CADC341CD; Tue, 5 Jul 2022 10:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657018015; bh=rfNQgOMFB8nJZ88z6VHSawhn/ud3uhg1LUo6vgVqxws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lOG3ebesYuzv8ZyPrzmGW418WG+LXhupvRyY1A9Cpldg4Igb7EDwnbByiKd/bDwtY uLLqfQKF/CyLDwrXzqkVZ3ePOqpMCimeaG0p74dg9DCUs9l65mp7hZOoVV3+vJYlnM B2Hkx2X6v8HHFoFv7/91Eyo38qJNsC0Qp3jJQKFc= Date: Tue, 5 Jul 2022 12:45:35 +0200 From: Greg Kroah-Hartman To: Mathieu Desnoyers Cc: Peter Zijlstra , RAJESH DASARI , stable , linux-kernel Subject: Re: Reg: rseq selftests failed on 5.4.199 Message-ID: References: <1331962917.52634.1656967894704.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331962917.52634.1656967894704.JavaMail.zimbra@efficios.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jul 04, 2022 at 04:51:34PM -0400, Mathieu Desnoyers wrote: > ----- On Jun 30, 2022, at 7:25 AM, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote: > > > On Mon, Jun 27, 2022 at 11:20:40AM -0400, Mathieu Desnoyers wrote: > >> On 27-Jun-2022 09:23:58 AM, Greg KH wrote: > >> > On Sun, Jun 26, 2022 at 10:01:20PM +0300, RAJESH DASARI wrote: > >> > > Hi , > >> > > > >> > > We are running rseq selftests on 5.4.199 kernel with glibc 2.34 > >> > > version and we see that tests are failing to compile with invalid > >> > > argument errors. When we took all the commits from > >> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/tools/testing/selftests/rseq > >> > > related to rseq locally , test cases have passed. I see that there are > >> > > some adaptations to the latest glibc version done in those commits, is > >> > > there any plan to backport them to 5.4.x versions. Could you please > >> > > provide your inputs. > >> > > >> > What commits specifically are you referring to please? A list of them > >> > would be great, and if you have tested them and verified that they can > >> > be backported cleanly would also be very helpful. > >> > >> Hi Greg, > >> > >> Specifically related to rseq selftests, the following string of commits > >> would be relevant on top of v5.4.199. Those are not all strictly only > >> bugfixes, but they help applying the following commits without > >> conflicts. I have validated that this string of commits cherry-picks on > >> top of v5.4.199, and that the resulting selftests build fine. > >> > >> ea366dd79c ("seq/selftests,x86_64: Add rseq_offset_deref_addv()") > >> 07ad4f7629 ("selftests/rseq: remove ARRAY_SIZE define from individual tests") > >> 5c105d55a9 ("selftests/rseq: introduce own copy of rseq uapi header") > >> 930378d056 ("selftests/rseq: Remove useless assignment to cpu variable") > >> 94b80a19eb ("selftests/rseq: Remove volatile from __rseq_abi") > >> e546cd48cc ("selftests/rseq: Introduce rseq_get_abi() helper") > >> 886ddfba93 ("selftests/rseq: Introduce thread pointer getters") > >> 233e667e1a ("selftests/rseq: Uplift rseq selftests for compatibility with > >> glibc-2.35") > >> 24d1136a29 ("selftests/rseq: Fix ppc32: wrong rseq_cs 32-bit field pointer on > >> big endian") > >> de6b52a214 ("selftests/rseq: Fix ppc32 missing instruction selection "u" and "x" > >> for load/store") > >> 26dc8a6d8e ("selftests/rseq: Fix ppc32 offsets by using long rather than off_t") > >> d7ed99ade3 ("selftests/rseq: Fix warnings about #if checks of undefined tokens") > >> 94c5cf2a0e ("selftests/rseq: Remove arm/mips asm goto compiler work-around") > >> b53823fb2e ("selftests/rseq: Fix: work-around asm goto compiler bugs") > >> 4e15bb766b ("selftests/rseq: x86-64: use %fs segment selector for accessing rseq > >> thread area") > >> 127b6429d2 ("selftests/rseq: x86-32: use %gs segment selector for accessing rseq > >> thread area") > >> 889c5d60fb ("selftests/rseq: Change type of rseq_offset to ptrdiff_t") > > > > As many of these are newer than 5.10, can you provide a series of > > patches that should be applied to 5.4, 5.10, 5.15 and possibly 5.18 to > > resolve this issue. We do not want anyone moving from 5.4 to a newer > > kernel and having regressions. > > Hi Greg, > > Here are the series of rseq selftests fixes to apply to the 5.4, 5.10, and 5.15 > stable kernel series. > > v5.4.203 > > ea366dd79c ("seq/selftests,x86_64: Add rseq_offset_deref_addv()") > 07ad4f7629 ("selftests/rseq: remove ARRAY_SIZE define from individual tests") > 5c105d55a9 ("selftests/rseq: introduce own copy of rseq uapi header") > 930378d056 ("selftests/rseq: Remove useless assignment to cpu variable") > 94b80a19eb ("selftests/rseq: Remove volatile from __rseq_abi") > e546cd48cc ("selftests/rseq: Introduce rseq_get_abi() helper") > 886ddfba93 ("selftests/rseq: Introduce thread pointer getters") > 233e667e1a ("selftests/rseq: Uplift rseq selftests for compatibility with glibc-2.35") > 24d1136a29 ("selftests/rseq: Fix ppc32: wrong rseq_cs 32-bit field pointer on big endian") > de6b52a214 ("selftests/rseq: Fix ppc32 missing instruction selection "u" and "x" for load/store") > 26dc8a6d8e ("selftests/rseq: Fix ppc32 offsets by using long rather than off_t") > d7ed99ade3 ("selftests/rseq: Fix warnings about #if checks of undefined tokens") > 94c5cf2a0e ("selftests/rseq: Remove arm/mips asm goto compiler work-around") > b53823fb2e ("selftests/rseq: Fix: work-around asm goto compiler bugs") > 4e15bb766b ("selftests/rseq: x86-64: use %fs segment selector for accessing rseq thread area") > 127b6429d2 ("selftests/rseq: x86-32: use %gs segment selector for accessing rseq thread area") > 889c5d60fb ("selftests/rseq: Change type of rseq_offset to ptrdiff_t") > > v5.10.128 > > 07ad4f7629 ("selftests/rseq: remove ARRAY_SIZE define from individual tests") > 5c105d55a9 ("selftests/rseq: introduce own copy of rseq uapi header") > 930378d056 ("selftests/rseq: Remove useless assignment to cpu variable") > 94b80a19eb ("selftests/rseq: Remove volatile from __rseq_abi") > e546cd48cc ("selftests/rseq: Introduce rseq_get_abi() helper") > 886ddfba93 ("selftests/rseq: Introduce thread pointer getters") > 233e667e1a ("selftests/rseq: Uplift rseq selftests for compatibility with glibc-2.35") > 24d1136a29 ("selftests/rseq: Fix ppc32: wrong rseq_cs 32-bit field pointer on big endian") > de6b52a214 ("selftests/rseq: Fix ppc32 missing instruction selection "u" and "x" for load/store") > 26dc8a6d8e ("selftests/rseq: Fix ppc32 offsets by using long rather than off_t") > d7ed99ade3 ("selftests/rseq: Fix warnings about #if checks of undefined tokens") > 94c5cf2a0e ("selftests/rseq: Remove arm/mips asm goto compiler work-around") > b53823fb2e ("selftests/rseq: Fix: work-around asm goto compiler bugs") > 4e15bb766b ("selftests/rseq: x86-64: use %fs segment selector for accessing rseq thread area") > 127b6429d2 ("selftests/rseq: x86-32: use %gs segment selector for accessing rseq thread area") > 889c5d60fb ("selftests/rseq: Change type of rseq_offset to ptrdiff_t") > > v5.15.52 > > 07ad4f7629 ("selftests/rseq: remove ARRAY_SIZE define from individual tests") > 5c105d55a9 ("selftests/rseq: introduce own copy of rseq uapi header") > 930378d056 ("selftests/rseq: Remove useless assignment to cpu variable") > 94b80a19eb ("selftests/rseq: Remove volatile from __rseq_abi") > e546cd48cc ("selftests/rseq: Introduce rseq_get_abi() helper") > 886ddfba93 ("selftests/rseq: Introduce thread pointer getters") > 233e667e1a ("selftests/rseq: Uplift rseq selftests for compatibility with glibc-2.35") > 24d1136a29 ("selftests/rseq: Fix ppc32: wrong rseq_cs 32-bit field pointer on big endian") > de6b52a214 ("selftests/rseq: Fix ppc32 missing instruction selection "u" and "x" for load/store") > 26dc8a6d8e ("selftests/rseq: Fix ppc32 offsets by using long rather than off_t") > d7ed99ade3 ("selftests/rseq: Fix warnings about #if checks of undefined tokens") > 94c5cf2a0e ("selftests/rseq: Remove arm/mips asm goto compiler work-around") > b53823fb2e ("selftests/rseq: Fix: work-around asm goto compiler bugs") > 4e15bb766b ("selftests/rseq: x86-64: use %fs segment selector for accessing rseq thread area") > 127b6429d2 ("selftests/rseq: x86-32: use %gs segment selector for accessing rseq thread area") > 889c5d60fb ("selftests/rseq: Change type of rseq_offset to ptrdiff_t") Thanks, all now queued up. greg k-h