public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jimmy Assarsson <extja@kvaser.com>
Cc: stable@vger.kernel.org, linux-can@vger.kernel.org,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Jimmy Assarsson <jimmyassarsson@gmail.com>
Subject: Re: [PATCH 5.15 0/3] can: kvaser_usb: CAN clock frequency regression
Date: Sun, 10 Jul 2022 16:22:24 +0200	[thread overview]
Message-ID: <YsrgoLKzoveR4/R4@kroah.com> (raw)
In-Reply-To: <20220708184846.281174-1-extja@kvaser.com>

On Fri, Jul 08, 2022 at 08:48:43PM +0200, Jimmy Assarsson wrote:
> Backport of upstream patch series [1].
> 
> When fixing the CAN clock frequency,
> fb12797ab1fe ("can: kvaser_usb: get CAN clock frequency from device"),
> I introduced a regression.
> 
> For Leaf devices based on M32C, the firmware expects bittiming parameters
> calculated for 16MHz clock. Regardless of the actual clock frequency.
> 
> This regression affects M32C based Leaf devices with non-16MHz clock.
> 
> Also correct the bittiming constants in kvaser_usb_leaf.c, where the
> limits are different depending on which firmware/device being used.
> 
> [1]
> https://lore.kernel.org/linux-can/20220603083820.800246-1-extja@kvaser.com/
> 
> Jimmy Assarsson (3):
>   can: kvaser_usb: replace run-time checks with struct
>     kvaser_usb_driver_info
>   can: kvaser_usb: kvaser_usb_leaf: fix CAN clock frequency regression
>   can: kvaser_usb: kvaser_usb_leaf: fix bittiming limits
> 
>  drivers/net/can/usb/kvaser_usb/kvaser_usb.h   |  25 +-
>  .../net/can/usb/kvaser_usb/kvaser_usb_core.c  | 286 ++++++++++--------
>  .../net/can/usb/kvaser_usb/kvaser_usb_hydra.c |   4 +-
>  .../net/can/usb/kvaser_usb/kvaser_usb_leaf.c  | 119 ++++----
>  4 files changed, 244 insertions(+), 190 deletions(-)
> 
> -- 
> 2.36.1
> 

5.15, 5.10, 5.4, and 4.19 patches now queued up, thanks!

greg k-h

      parent reply	other threads:[~2022-07-10 14:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08 18:48 [PATCH 5.15 0/3] can: kvaser_usb: CAN clock frequency regression Jimmy Assarsson
2022-07-08 18:48 ` [PATCH 5.15 1/3] can: kvaser_usb: replace run-time checks with struct kvaser_usb_driver_info Jimmy Assarsson
2022-07-08 18:48 ` [PATCH 5.15 2/3] can: kvaser_usb: kvaser_usb_leaf: fix CAN clock frequency regression Jimmy Assarsson
2022-07-08 18:48 ` [PATCH 5.15 3/3] can: kvaser_usb: kvaser_usb_leaf: fix bittiming limits Jimmy Assarsson
2022-07-10 14:22 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsrgoLKzoveR4/R4@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=extja@kvaser.com \
    --cc=jimmyassarsson@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox