From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Daniel Sneddon <daniel.sneddon@linux.intel.com>,
antonio.gomez.iglesias@linux.intel.com
Subject: Re: [PATCH] x86/bugs: Switch to "auto" when "ibrs" selected on Enhanced IBRS parts
Date: Thu, 14 Jul 2022 20:11:29 +0200 [thread overview]
Message-ID: <YtBcUWIqJjUdWtro@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220714173814.p5kdyimu6ho7zjt5@treble>
On Thu, Jul 14, 2022 at 10:38:14AM -0700, Josh Poimboeuf wrote:
> On Thu, Jul 14, 2022 at 07:03:32PM +0200, Peter Zijlstra wrote:
> > On Thu, Jul 14, 2022 at 09:01:06AM -0700, Josh Poimboeuf wrote:
> >
> > > > Yeah this; if the user asks for IBRS, we should give him IBRS. I hate
> > > > the 'I know better, let me change that for you' mentality.
> > >
> > > eIBRS CPUs don't even have legacy IBRS so I don't see how this is even
> > > possible.
> >
> > You can still WRMSR a lot on them. Might not make sense but it 'works'.
>
> Even in Intel documentation, eIBRS is often referred to as IBRS. It
> wouldn't be surprising for a user to consider spectre_v2=ibrs to mean
> "use eIBRS".
>
> I'm pretty sure there's nobody out there that wants spectre_v2=ibrs to
> mean "make it slower and possibly less secure because it's being used
> contrary to the spec".
Then make it print a big honking warning.
Most people will either use auto or off, the very few people that force
an option get what they ask for, not something else.
Like said upthread, it allows testing the code-paths at the very least.
next prev parent reply other threads:[~2022-07-14 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 5:32 [PATCH] x86/bugs: Switch to "auto" when "ibrs" selected on Enhanced IBRS parts Pawan Gupta
2022-07-14 11:17 ` Thadeu Lima de Souza Cascardo
2022-07-14 11:42 ` Peter Zijlstra
2022-07-14 14:59 ` Pawan Gupta
2022-07-14 16:01 ` Josh Poimboeuf
2022-07-14 17:03 ` Peter Zijlstra
2022-07-14 17:38 ` Josh Poimboeuf
2022-07-14 18:11 ` Peter Zijlstra [this message]
2022-07-14 18:42 ` Pawan Gupta
2022-07-14 23:15 ` [PATCH v2] x86/bugs: Warn when "ibrs" mitigation is " Pawan Gupta
2022-07-15 0:11 ` Thadeu Lima de Souza Cascardo
2022-07-15 2:00 ` Pawan Gupta
2022-07-15 5:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtBcUWIqJjUdWtro@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=antonio.gomez.iglesias@linux.intel.com \
--cc=bp@alien8.de \
--cc=cascardo@canonical.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).