From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B10C43334 for ; Thu, 14 Jul 2022 18:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240834AbiGNSe2 (ORCPT ); Thu, 14 Jul 2022 14:34:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240776AbiGNSeJ (ORCPT ); Thu, 14 Jul 2022 14:34:09 -0400 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEBA152477 for ; Thu, 14 Jul 2022 11:34:03 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id BA5B6320010B; Thu, 14 Jul 2022 14:34:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 14 Jul 2022 14:34:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1657823641; x=1657910041; bh=7SaasPwrvv OmYU6zeU2IbJ7N3BqTdfMFMubq7UcA7Io=; b=jgtB5FLpOhYv43OCl2S3TLEaCM 2ZruTZI1lw+FAMtjEEsPsNvpb80HFY6jkALDuLdNuf2lMPyPzDqa009+apxUP8RF uZOZdVB0xY3xUkCwVWFmesoagPvbN17IpnBo6KSMHEdAo4b29rUw+fb1kQEba22W qumpIRyqXJttLbm33cYJZMOK6PChXAT+TQ6BW9q2w+eTTP7vooPEZ9iSnD6D9mo9 v/n/7bP1XR5hmkELtl8LgaXoihnU5/de8rBDSelMdV5lLfMXHvoHn+rJxDAmHzuQ JBEs4OgwsHsqQZ307eHsiDDMW7NLCrRt1xUd/WpAI9A6QxRYbPlJfKZG7eKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657823641; x=1657910041; bh=7SaasPwrvvOmYU6zeU2IbJ7N3BqT dfMFMubq7UcA7Io=; b=Jxyul80yrW/oPwB+dnpa5FdZtvy57gkXREXpKbfUQXmm mn4H6py4lV3O9XIOFvxjY+1eFkeV64Gbzk3qY6pJY/g0lyDBcfZ0O5lo0wHuhWEk a8SbCY138nzdoFMMgxOvLifyMgAa2cZv19y13rv5pobDSlT0LOYesmopnLrkcMh5 LzYCnvhV/Xgh9m3U/1hrzDYuIrrM72DzEAvMEWfTR89PQCzQmkZFshXzv93bRM7R V8ud0d1wuzxnk47haDRWttW6xOHv9R1gjCZ5l6YbFGV2ujhinUuh6Ia/9BdJj0B0 XKSY1GdK6njr6zMZIKCh4ub7iCNEyNMmB2l8V3pVDQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejledguddvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdortddttddvnecuhfhrohhmpefirhgv ghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeejhf elffejkeejheetgfeigeekueeuuddvveekjeekueeggfdvhfefteelgefgvdenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhroh grhhdrtghomh X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Jul 2022 14:34:00 -0400 (EDT) Date: Thu, 14 Jul 2022 20:33:56 +0200 From: Greg KH To: James Morse Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Sumit Gupta Subject: Re: [stable:PATCH v4.9.323] arm64: entry: Restore tramp_map_kernel ISB Message-ID: References: <20220714162225.280073-1-james.morse@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220714162225.280073-1-james.morse@arm.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jul 14, 2022 at 05:22:25PM +0100, James Morse wrote: > Summit reports that the BHB backports for v4.9 prevent vulnerable > platforms from booting when CONFIG_RANDOMIZE_BASE is enabled. > > This is because the trampoline code takes a translation fault when > accessing the data page, because the TTBR write hasn't been completed > by an ISB before the access is made. > > Upstream has a complex erratum workaround for QCOM_FALKOR_E1003 in > this area, which removes the ISB when the workaround has been applied. > v4.9 lacks this workaround, but should still have the ISB. > > Restore the barrier. > > Fixes: aee10c2dd013 ("arm64: entry: Add macro for reading symbol addresses from the trampoline") > Reported-by: Sumit Gupta > Tested-by: Sumit Gupta > Cc: > Signed-off-by: James Morse > --- > This only applies to the v4.9 backport, as v4.14 has the QCOM_FALKOR_E1003 > workaround. > > arch/arm64/kernel/entry.S | 1 + > 1 file changed, 1 insertion(+) Now queued up, thanks. greg k-h