public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jose Alonso <joalonsof@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>, stable <stable@vger.kernel.org>,
	Ronald Wahl <ronald.wahl@raritan.com>
Subject: Re: [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
Date: Fri, 5 Aug 2022 20:26:46 +0200	[thread overview]
Message-ID: <Yu1g5rjY9kkib1YV@kroah.com> (raw)
In-Reply-To: <dc920ea721a8846c49e7a8752e8d3209edd94f4e.camel@gmail.com>

On Fri, Aug 05, 2022 at 03:08:40PM -0300, Jose Alonso wrote:
> The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware versions
> that have no issues.
> 
> This patch is reverting 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
> because using FLAG_SEND_ZLP in this context is not safe.
> See:
> https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378

Please wrap (but not the url) at 72 columns like your editor asked you
to :)

> 
> reported by:
> Ronald Wahl <ronald.wahl@raritan.com>

Should be:

Reported-by: Ronald Wahl <ronald.wahl@raritan.com>

> https://bugzilla.kernel.org/show_bug.cgi?id=216327
> https://bugs.archlinux.org/task/75491

Those should be "Link:" references.

And you need a cc: stable and/or a "Fixes:" tag please.

Also there is a normal template that 'git revert' gives you, why not use
that?

thanks,

greg k-h

  reply	other threads:[~2022-08-05 18:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 18:08 [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP Jose Alonso
2022-08-05 18:26 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-08-05 20:02 Jose Alonso
2022-08-06  4:47 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yu1g5rjY9kkib1YV@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=joalonsof@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ronald.wahl@raritan.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox