From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A4DC04A68 for ; Wed, 27 Jul 2022 19:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232957AbiG0TAf (ORCPT ); Wed, 27 Jul 2022 15:00:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbiG0TAP (ORCPT ); Wed, 27 Jul 2022 15:00:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC11374DF5; Wed, 27 Jul 2022 11:11:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5974D61988; Wed, 27 Jul 2022 18:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AD6EC433C1; Wed, 27 Jul 2022 18:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658945466; bh=Mom6Ph0FsAAZ+C+h67Qnnz+WO0GGSqzSCicWOfVwSFc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RuKOM3Ol94eIS35+inrZhT7DED0Yq1YgX9yUMQFL7diTl8EruJ3Xk+o8nrTVlyX7a H7msQA5o2kYik/cqyALUfZN9FHx4wehSeGCpNxzqqHZp8RhzOnK1bowgIn8SYa4gfQ 3MNzOqVTdOJhOAJVxDb4SdE4zZ+1osqEyrQ7pI4Q= Date: Wed, 27 Jul 2022 20:11:03 +0200 From: Greg Kroah-Hartman To: Luis Chamberlain Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Xiaoming Ni , Kees Cook , Al Viro , Amir Goldstein , Andy Shevchenko , Benjamin LaHaise , "Eric W. Biederman" , Iurii Zaikin , Jan Kara , Paul Turner , Peter Zijlstra , Petr Mladek , Qing Wang , Sebastian Reichel , Sergey Senozhatsky , Stephen Kitt , Tetsuo Handa , Antti Palosaari , Arnd Bergmann , Benjamin Herrenschmidt , Clemens Ladisch , David Airlie , Jani Nikula , Joel Becker , Joonas Lahtinen , Joseph Qi , Julia Lawall , Lukas Middendorf , Mark Fasheh , Phillip Potter , Rodrigo Vivi , Douglas Gilbert , "James E.J. Bottomley" , Jani Nikula , John Ogness , "Martin K. Petersen" , "Rafael J. Wysocki" , "Steven Rostedt (VMware)" , Suren Baghdasaryan , Theodore Tso , Andrew Morton , Linus Torvalds , Sasha Levin Subject: Re: [PATCH 5.15 040/201] sysctl: move some boundary constants from sysctl.c to sysctl_vals Message-ID: References: <20220727161026.977588183@linuxfoundation.org> <20220727161028.534205480@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jul 27, 2022 at 10:31:37AM -0700, Luis Chamberlain wrote: > On Wed, Jul 27, 2022 at 06:09:04PM +0200, Greg Kroah-Hartman wrote: > > From: Xiaoming Ni > > > > [ Upstream commit 78e36f3b0dae586f623c4a37ec5eb5496f5abbe1 ] > > > > sysctl has helpers which let us specify boundary values for a min or max > > int value. Since these are used for a boundary check only they don't > > change, so move these variables to sysctl_vals to avoid adding duplicate > > variables. This will help with our cleanup of kernel/sysctl.c. > > > > [akpm@linux-foundation.org: update it for "mm/pagealloc: sysctl: change watermark_scale_factor max limit to 30%"] > > [mcgrof@kernel.org: major rebase] > > > > Link: https://lkml.kernel.org/r/20211123202347.818157-3-mcgrof@kernel.org > > Signed-off-by: Xiaoming Ni > > Signed-off-by: Luis Chamberlain > > Reviewed-by: Kees Cook > > Signed-off-by: Andrew Morton > > Signed-off-by: Linus Torvalds > > Signed-off-by: Sasha Levin > > I'm a bit puzzled. How / why is this a stable fix? I think it's needed by a patch later in the series. Sasha, can you verify? thanks, greg k-h