Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Coiby Xu <coxu@redhat.com>
Cc: bhe@redhat.com, msuchanek@suse.de, will@kernel.org,
	zohar@linux.ibm.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] arm64: kexec_file: use more system keyrings to verify kernel" failed to apply to 5.10-stable tree
Date: Fri, 19 Aug 2022 16:48:52 +0200	[thread overview]
Message-ID: <Yv+i1Eo+0c+nw5/n@kroah.com> (raw)
In-Reply-To: <Yv+hy5nWTPpei0C5@kroah.com>

On Fri, Aug 19, 2022 at 04:44:27PM +0200, Greg KH wrote:
> On Thu, Aug 18, 2022 at 12:15:36PM +0800, Coiby Xu wrote:
> > Hi Greg,
> > 
> > 
> > This patch depends on three prerequisites. This full list of commit ids
> > should be backported is shown below,
> > 
> > 1. 65d9a9a60fd7 ("kexec_file: drop weak attribute from functions")
> > 2. 689a71493bd2 ("kexec: clean up arch_kexec_kernel_verify_sig")
> > 3. c903dae8941d ("kexec, KEYS: make the code in bzImage64_verify_sig generic")
> > 4. 0d519cadf751 ("arm64: kexec_file: use more system keyrings to verify kernel image signature")
> > 
> > $ git checkout -b arm_key_5.10.y stable/linux-5.10.y
> > Updating files: 100% (33255/33255), done.
> > branch 'arm_key_5.10.y' set up to track 'stable/linux-5.10.y'.
> > Switched to a new branch 'arm_key_5.10.y'
> > $ git cherry-pick 65d9a9a60fd7 689a71493bd2 c903dae8941d 0d519cadf751
> > Auto-merging arch/arm64/include/asm/kexec.h
> > Auto-merging arch/powerpc/include/asm/kexec.h
> > Auto-merging arch/s390/include/asm/kexec.h
> > Auto-merging arch/x86/include/asm/kexec.h
> > Auto-merging include/linux/kexec.h
> > Auto-merging kernel/kexec_file.c
> > [arm_key_5.10.y 624dfcf3b8de] kexec_file: drop weak attribute from functions
> >  Author: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> >  Date: Fri Jul 1 13:04:04 2022 +0530
> >  6 files changed, 61 insertions(+), 40 deletions(-)
> > Auto-merging include/linux/kexec.h
> > Auto-merging kernel/kexec_file.c
> > [arm_key_5.10.y da8cfa52682e] kexec: clean up arch_kexec_kernel_verify_sig
> >  Date: Thu Jul 14 21:40:24 2022 +0800
> >  2 files changed, 13 insertions(+), 25 deletions(-)
> > Auto-merging arch/x86/kernel/kexec-bzimage64.c
> > Auto-merging include/linux/kexec.h
> > Auto-merging kernel/kexec_file.c
> > [arm_key_5.10.y 0bb032082ce6] kexec, KEYS: make the code in bzImage64_verify_sig generic
> >  Date: Thu Jul 14 21:40:25 2022 +0800
> >  3 files changed, 25 insertions(+), 19 deletions(-)
> > [arm_key_5.10.y fde64a36fa74] arm64: kexec_file: use more system keyrings to verify kernel image signature
> >  Date: Thu Jul 14 21:40:26 2022 +0800
> >  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> Now queued up, thanks.

Ooops, nope, that broke the build:

ld: kernel/kexec_file.o: in function `kimage_file_post_load_cleanup':
kexec_file.c:(.text+0xde0): undefined reference to `arch_kimage_file_post_load_cleanup'
make: *** [Makefile:1193: vmlinux] Error 1

Please send me the full set of patches needed here to get this to work,
if it's really needed in the 5.10.y tree.

thanks,

greg k-h

      reply	other threads:[~2022-08-19 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 15:33 FAILED: patch "[PATCH] arm64: kexec_file: use more system keyrings to verify kernel" failed to apply to 5.10-stable tree gregkh
2022-08-18  4:15 ` Coiby Xu
2022-08-19 14:44   ` Greg KH
2022-08-19 14:48     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv+i1Eo+0c+nw5/n@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhe@redhat.com \
    --cc=coxu@redhat.com \
    --cc=msuchanek@suse.de \
    --cc=stable@vger.kernel.org \
    --cc=will@kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox