From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7650C6FA82 for ; Mon, 12 Sep 2022 14:40:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbiILOkF (ORCPT ); Mon, 12 Sep 2022 10:40:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbiILOkD (ORCPT ); Mon, 12 Sep 2022 10:40:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7C006309 for ; Mon, 12 Sep 2022 07:39:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C0E6061228 for ; Mon, 12 Sep 2022 14:39:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6A30C433C1; Mon, 12 Sep 2022 14:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662993598; bh=Ah3VceZLK7rGhdOmh3p7++iiHDeZVBPs87sAg+dcHBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2SyoB2it1Xb+lnL/Nz99ZQhYTppduPkcDGz96NaAMxvNmchw5UDS3BIB5WAZDKNX7 tWaIkfFd6y01RUdNLcA7b10Q29q3FKe8d7tHqMRGNL7Bczju0YWxX3JGIHAkneG2ZT bAySmzACydmXG1xVns9odDbtQfEUS8HyNYUOSDpU= Date: Mon, 12 Sep 2022 16:40:22 +0200 From: Greg Kroah-Hartman To: Jisheng Zhang Cc: stable@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Ian Rogers , Jiri Olsa , Namhyung Kim Subject: Re: [PATCH linux-5.15.y v2] perf machine: Use path__join() to compose a path instead of snprintf(dir, '/', filename) Message-ID: References: <20220912081522.4067-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220912081522.4067-1-jszhang@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Sep 12, 2022 at 04:15:22PM +0800, Jisheng Zhang wrote: > From: Arnaldo Carvalho de Melo > > commit 9d5f0c36438eeae7566ca383b2b673179e3cc613 upstream. > > Its more intention revealing, and if we're interested in the odd cases > where this may end up truncating we can do debug checks at one > centralized place. > > Motivation, of all the container builds, fedora rawhide started > complaining of: > > util/machine.c: In function ‘machine__create_modules’: > util/machine.c:1419:50: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 0 and 4095 [-Werror=format-truncation=] > 1419 | snprintf(path, sizeof(path), "%s/%s", dir_name, dent->d_name); > | ^~ > In file included from /usr/include/stdio.h:894, > from util/branch.h:9, > from util/callchain.h:8, > from util/machine.c:7: > In function ‘snprintf’, > inlined from ‘maps__set_modules_path_dir’ at util/machine.c:1419:3, > inlined from ‘machine__set_modules_path’ at util/machine.c:1473:9, > inlined from ‘machine__create_modules’ at util/machine.c:1519:7: > /usr/include/bits/stdio2.h:71:10: note: ‘__builtin___snprintf_chk’ output between 2 and 4352 bytes into a destination of size 4096 > > There are other places where we should use path__join(), but lets get rid of > this one first. > > Cc: Adrian Hunter > Cc: Ian Rogers > Cc: Jiri Olsa > Cc: Namhyung Kim > Acked-by: Ian Rogers > Link: Link: https://lore.kernel.org/r/YebZKjwgfdOz0lAs@kernel.org > Signed-off-by: Arnaldo Carvalho de Melo As you are forwarding on this commit, you too need to sign-off on it. > --- > > Since v1: > - add commit id in upstream. > - add linux-5.15.y, maybe we also need this for other long term stable > tree. Why is this needed in 5.15? thanks, greg k-h