Re: [PATCH v3 2/2] net: dp83822: disable rx error interrupt

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Sep 12, 2022 at 06:07:08AM -0400, Enguerrand de Ribaucourt wrote:
> > From: "Greg KH" <gregkh@linuxfoundation.org>
> > To: "Enguerrand de Ribaucourt" <enguerrand.de-ribaucourt@savoirfairelinux.com>
> > Cc: stable@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>, "Jakub Kicinski" <kuba@kernel.org>
> > Sent: Thursday, September 8, 2022 7:09:02 PM
> > Subject: Re: [PATCH v3 2/2] net: dp83822: disable rx error interrupt
> 
> > On Wed, Sep 07, 2022 at 12:45:59PM +0200, Enguerrand de Ribaucourt wrote:
> > > Some RX errors, notably when disconnecting the cable, increase the RCSR
> > > register. Once half full (0x7fff), an interrupt flood is generated. I
> > > measured ~3k/s interrupts even after the RX errors transfer was
> > > stopped.
> 
> > > Since we don't read and clear the RCSR register, we should disable this
> > > interrupt.
> 
> > > Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
> >> Signed-off-by: Enguerrand de Ribaucourt
> > > <enguerrand.de-ribaucourt@savoirfairelinux.com>
> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > > [backport of 5.10 commit 0e597e2affb90d6ea48df6890d882924acf71e19]
> > > ---
> > > drivers/net/phy/dp83822.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> > Does not apply to 5.4.y or 4.19.y :(
> 
> I could apply the patch with no problems on those versions. I also could cherry-pick
> the commit on the branch queue/5.4 from stable/linux-stable-rc.git without conflicts.
> 
> I can't reproduce the issue you seem to be facing when applying those patches. Would you
> mind helping me finding what's wrong with the patch on those branches?

I no longer have the original in my queue anywhere, can you just resend
the missing commits if you think it works properly?

thanks,

greg k-h