From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6ACECAAD3 for ; Thu, 1 Sep 2022 11:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233197AbiIALI4 (ORCPT ); Thu, 1 Sep 2022 07:08:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231484AbiIALIz (ORCPT ); Thu, 1 Sep 2022 07:08:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D9261321E8; Thu, 1 Sep 2022 04:08:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2995161D76; Thu, 1 Sep 2022 11:08:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1E29C433C1; Thu, 1 Sep 2022 11:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662030533; bh=GO5OWJyxvsNjXdz5eXwP4/4lg3DYoGMjM+O2CwFsH7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hf1MkGxfopSkLoYKyPfD0bOwVW4DvkvgULW5uBZRxcNaH5CfrxD6u95w3YyUfUOPx cjqA1lU+cYsX2olFRE+jHT8gkYOVG1BTcRgp4ei6pxztB32L115JGtsZ8BSkhhgtAN d8i6yXyIQ9/n195E+ExTOUkKFqCAcKPK0aHQM6HU= Date: Thu, 1 Sep 2022 13:08:50 +0200 From: Greg Kroah-Hartman To: Stefan Roese Cc: Bjorn Helgaas , Ben Greear , bjorn@helgaas.com, LKML , stable@vger.kernel.org, Bjorn Helgaas , Pali =?iso-8859-1?Q?Roh=E1r?= , "Rafael J. Wysocki" , Bharat Kumar Gogada , Michal Simek , Yao Hongbo , Naveen Naidu , Sasha Levin , Gregory Greenman , linux-wireless@vger.kernel.org Subject: Re: [PATCH 5.4 182/389] PCI/portdrv: Dont disable AER reporting in get_port_device_capability() Message-ID: References: <20220830221159.GA132418@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Aug 31, 2022 at 07:52:00AM +0200, Stefan Roese wrote: > On 31.08.22 00:11, Bjorn Helgaas wrote: > > [+cc Gregory, linux-wireless for iwlwifi issue] > > > > On Tue, Aug 30, 2022 at 01:47:48PM -0700, Ben Greear wrote: > > > On 8/23/22 11:41 PM, Greg Kroah-Hartman wrote: > > > > On Tue, Aug 23, 2022 at 07:20:14AM -0500, Bjorn Helgaas wrote: > > > > > On Tue, Aug 23, 2022, 6:35 AM Greg Kroah-Hartman > > > > > wrote: > > > > > > > > > > > From: Stefan Roese > > > > > > > > > > > > [ Upstream commit 8795e182b02dc87e343c79e73af6b8b7f9c5e635 ] > > > > > > > > > > > > > > > > There's an open regression related to this commit: > > > > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=216373 > > > > > > > > This is already in the following released stable kernels: > > > > 5.10.137 5.15.61 5.18.18 5.19.2 > > > > > > > > I'll go drop it from the 4.19 and 5.4 queues, but when this gets > > > > resolved in Linus's tree, make sure there's a cc: stable on the fix so > > > > that we know to backport it to the above branches as well. Or at the > > > > least, a "Fixes:" tag. > > > > > > This is still in 5.19.5. We saw some funny iwlwifi crashes in 5.19.3+ > > > that we did not see in 5.19.0+. I just bisected the scary looking > > > AER errors to this patch, though I do not know for certain if it > > > causes the iwlwifi related crashes yet. > > > > > > In general, from reading the commit msg, this patch doesn't seem to > > > be a great candidate for stable in general. Does it fix some > > > important problem? > > > > I agree, I don't think this is a good candidate for stable. It has > > already exposed latent amdgpu issues and we'll likely find more. It's > > good to find and fix these things, but I'd rather do it in -rc than in > > stable kernels. > > I also agree. It was not my intention to have this patch added to > the stable branches. Frankly I missed intervening when seeing the > mails about the integration into stable a few weeks ago. It was maked with a Fixes: tag, which makes it ripe for backporting, especially as it is written as "this fixes this problem". Anyway, I've now reverted it from the stable trees. Hopefully you all get this figured out so that 6.0 doesn't have the same issue. thanks, greg k-h