From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B5AC54EE9 for ; Thu, 1 Sep 2022 13:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233999AbiIANMQ (ORCPT ); Thu, 1 Sep 2022 09:12:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234002AbiIANLf (ORCPT ); Thu, 1 Sep 2022 09:11:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC0F85303A; Thu, 1 Sep 2022 06:07:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F338B8263E; Thu, 1 Sep 2022 13:07:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E3F7C433C1; Thu, 1 Sep 2022 13:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662037656; bh=fkZEmaZoVvoyPmctVOyAmSTzIu4rPdqDgi8UTOZaUn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Isepg++kEaFrlFDLw7gC1ZrFXphhI04e6YSS21Vggtjb0PFTry8z3T19x7x8uBmRT LHpr0LtkLCQiuEueMeXzXCpD9FLm1q9pV2FCY1BC5RDJA4dHOg/HsoPP2mxnm3xhaI USPlzjQY1U+2RuscCIE1wocS6NvATb1GQfzC+ce0= Date: Thu, 1 Sep 2022 15:07:33 +0200 From: Greg Kroah-Hartman To: Amir Goldstein Cc: Frank Hofmann , Sasha Levin , "Darrick J . Wong" , Leah Rumancik , Chandan Babu R , Luis Chamberlain , Adam Manzanares , linux-xfs , stable , Dave Chinner , "Darrick J . Wong" , Dave Chinner Subject: Re: [PATCH 5.10 v2 6/7] xfs: reorder iunlink remove operation in xfs_ifree Message-ID: References: <20220901054854.2449416-1-amir73il@gmail.com> <20220901054854.2449416-7-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Sep 01, 2022 at 03:37:59PM +0300, Amir Goldstein wrote: > On Thu, Sep 1, 2022 at 1:26 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Sep 01, 2022 at 01:16:33PM +0300, Amir Goldstein wrote: > > > On Thu, Sep 1, 2022 at 12:41 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Thu, Sep 01, 2022 at 12:30:13PM +0300, Amir Goldstein wrote: > > > > > On Thu, Sep 1, 2022 at 12:04 PM Frank Hofmann wrote: > > > > > > > > > > > > On Thu, Sep 1, 2022 at 6:49 AM Amir Goldstein wrote: > > > > > > > > > > > > > > From: Dave Chinner > > > > > > > > > > > > > > commit 9a5280b312e2e7898b6397b2ca3cfd03f67d7be1 upstream. > > > > > > > > > > > > > > [backport for 5.10.y] > > > > > > > > > > > > Hi Amir, hi Dave, > > > > > > > > > > > > I've got no objections to backporting this change at all. We've been > > > > > > using the patch on our internal 5.15 tracker branch happily for > > > > > > several months now. > > > > > > > > > > > > Would like to highlight though that it's currently not yet merged in > > > > > > linux-stable 5.15 branch either (it's in 5.19 and mainline alright). > > > > > > If this gets queued for 5.10 then maybe it also should be for 5.15 ? > > > > > > > > > > > > > > > > Hi Frank, > > > > > > > > > > Quoting from my cover letter: > > > > > > > > > > Patches 6-7 in this 5.10.y update have not been applied to 5.15.y yet. > > > > > I pointed Leah's attention to these patches and she said she will > > > > > include them in a following 5.15.y update. > > > > > > > > And as you know, this means I can't take this series at all until that > > > > series is ready, so to help us out, in the future, just don't even send > > > > them until they are all ready together. > > > > > > > > > > What? > > > > > > You cannot take backports to 5.10.y before they are applied to 5.15.y? > > > Since when? > > > > Since always. > > > > Why would you ever want someone to upgrade from an older tree (like > > 5.10.y) to a newer one (5.15.y) and have a regression? > > > > That is certainly not a goal when backporting fixes to 5.10.y, but it > can happen as a by-product of the decentralized nature of testing > backports. > > But it did not bother you when xfs patches were applied to 5.4.y and > no xfs patches at all applied to 5.10.y for two years? I've been bothered by xfs patches for so long that really, I didn't care as the maintainers didn't seem bothered either :) But now that everything is working properly, let's do it correctly please. > > So we always try to make sure patches are always applied to newer trees > > first. Yes, sometimes we miss this and make mistakes, but it's always > > been this way and we fix that whenever it happens accidentally. > > > > That is my intention. > I will try to keep to that rule in the future. > I would have waited for the patches to land in 5.15.y, but > Leah got distracted by another task so I decided to not wait, > knowing that the patches are already in her queue. > > > I'll drop this series from my review queue for now until the 5.15.y > > series shows up. > > Please don't drop the series. > Please drop patches 6-7 if you must > Or if you insist I can re-post patches 1-5. Please resend as just the correct ones that you want so I know what to pick exactly. thanks, greg k-h