public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: stable@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH stable-5.10 1/1] io_uring: disable polling pollfree files
Date: Fri, 2 Sep 2022 08:13:43 +0200	[thread overview]
Message-ID: <YxGfF7hQOGa6lKMt@kroah.com> (raw)
In-Reply-To: <756d8d67-7a63-62a1-51e4-1e966f40610d@gmail.com>

On Thu, Sep 01, 2022 at 04:25:46PM +0100, Pavel Begunkov wrote:
> On 9/1/22 16:16, Pavel Begunkov wrote:
> > Older kernels lack io_uring POLLFREE handling. As only affected files
> > are signalfd and android binder the safest option would be to disable
> > polling those files via io_uring and hope there are no users.
> 
> It differs from how it's fixed upstream, but IMHO porting is too
> difficult to be reliable enough, this one is quick and simple.
> The upstream fix:
> 
> commit 791f3465c4afde02d7f16cf7424ca87070b69396
> Author: Pavel Begunkov <asml.silence@gmail.com>
> Date:   Fri Jan 14 11:59:10 2022 +0000
> 
>     io_uring: fix UAF due to missing POLLFREE handling
> 
> 
> I also forgot Fixes tag if required:
> 
> Fixes: 221c5eb233823 ("io_uring: add support for IORING_OP_POLL")

I'll go add it by hand, all now queued up, thanks!

greg k-h

  reply	other threads:[~2022-09-02  6:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 15:16 [PATCH stable-5.10 1/1] io_uring: disable polling pollfree files Pavel Begunkov
2022-09-01 15:25 ` Pavel Begunkov
2022-09-02  6:13   ` Greg KH [this message]
2022-09-02 10:38     ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxGfF7hQOGa6lKMt@kroah.com \
    --to=greg@kroah.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox