From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C347BECAAA1 for ; Tue, 6 Sep 2022 12:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237050AbiIFMCj (ORCPT ); Tue, 6 Sep 2022 08:02:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232906AbiIFMCe (ORCPT ); Tue, 6 Sep 2022 08:02:34 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06DF479637 for ; Tue, 6 Sep 2022 05:02:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 97CADB8188A for ; Tue, 6 Sep 2022 12:02:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E662C433C1; Tue, 6 Sep 2022 12:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662465747; bh=haGz2JSkeUqopu/71UJkO4kBXmyLwgD8UHtX20K4/5A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IxRl9cFYk3ovEqFSsIuDNaxJrKH4U9YTDtMSzkH5qlnU9R8ZC8o1G5WfWo1/1jw3t 0MSizTZTiCaFiEP+MfGxVykJlX4VIiJHwihLWm1D8/5Y7np9W+Z8PNsJyr+MrY3oos FosrX/oTXH/3killGG20FKM3TJbxpZ6rLf1R8yVg= Date: Tue, 6 Sep 2022 14:02:24 +0200 From: Greg KH To: Adrian Hunter Cc: stable@vger.kernel.org, Ulf Hansson , Seunghui Lee Subject: Re: [PATCH 5.10] mmc: core: Fix UHS-I SD 1.8V workaround branch Message-ID: References: <20220906060834.58305-1-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906060834.58305-1-adrian.hunter@intel.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Sep 06, 2022 at 09:08:34AM +0300, Adrian Hunter wrote: > commit 15c56208c79c340686869c31595c209d1431c5e8 upstream. > > When introduced, upon success, the 1.8V fixup workaround in > mmc_sd_init_card() would branch to practically the end of the function, to > a label named "done". Unfortunately, perhaps due to the label name, over > time new code has been added that really should have come after "done" not > before it. Let's fix the problem by moving the label to the correct place > and rename it "cont". > > Fixes: 045d705dc1fb ("mmc: core: Enable the MMC host software queue for the SD card") > Signed-off-by: Adrian Hunter > Reviewed-by: Seunghui Lee > Cc: stable@vger.kernel.org > Link: https://lore.kernel.org/r/20220815073321.63382-2-adrian.hunter@intel.com > Signed-off-by: Ulf Hansson > [Backport to 5.10] > Signed-off-by: Adrian Hunter > --- > drivers/mmc/core/sd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Now queued up, thanks. greg k-h