From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38385ECAAD5 for ; Fri, 9 Sep 2022 01:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229455AbiIIBVw (ORCPT ); Thu, 8 Sep 2022 21:21:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiIIBVv (ORCPT ); Thu, 8 Sep 2022 21:21:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABEA410B032; Thu, 8 Sep 2022 18:21:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3374561DE3; Fri, 9 Sep 2022 01:21:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66532C433C1; Fri, 9 Sep 2022 01:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662686509; bh=fVPajho/aOku1+8nabWUPcT67X3OaItOI+7Sotm7FB8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T/d4eyoFdQxk8p+PjLpEOdlfzaANQNJguMj9T0/2rVrTISomyq4dO9J6/B9wwZ327 ZXKzlYzzzK4Rh1mwKxe+7V1Z1/XpfCaggPh9JwTbGkAWf61f/3UwZQtacdq4Iv5do/ ATaMTXBe6nVFU+P5b5LV1uzi7sXQsm0Vpfe52HLtOS7v5ZGJqxpDe7uTA7vNiqEekY X6iLjiSF36DXHQhGDcIKrQ9cvd6Mcblx4ske0Cpk//Bfgb4v7l330gkspuQfLfzETh GP15eKqlJLQcSQHiK/rQIwpSANrstQAdfbtRkv2fvfNIiVc4fZ185yc9IV8MeUMTKQ +Yb+dEfLjr+6Q== Date: Thu, 8 Sep 2022 21:21:48 -0400 From: Sasha Levin To: =?iso-8859-1?B?Q3Pza+Fz?= Bence Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David S . Miller" , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.19 24/33] fec: Restart PPS after link state change Message-ID: References: <20220830171825.580603-1-sashal@kernel.org> <20220830171825.580603-24-sashal@kernel.org> <243d3362-403d-7a94-34fa-12385100cc53@prolan.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <243d3362-403d-7a94-34fa-12385100cc53@prolan.hu> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Aug 31, 2022 at 03:02:46PM +0200, Csókás Bence wrote: > >On 2022. 08. 30. 19:18, Sasha Levin wrote: >>From: Csókás Bence >> >>[ Upstream commit f79959220fa5fbda939592bf91c7a9ea90419040 ] >> >>On link state change, the controller gets reset, >>causing PPS to drop out and the PHC to lose its >>time and calibration. So we restart it if needed, >>restoring calibration and time registers. > >There is an ongoing investigation on netdev@ about a potential kernel >panic on kernels newer than 5.12 with this patch applied. Please hold >off on backporting to 5.19 until the bugfix is applied to upstream. Will do. -- Thanks, Sasha