From: Greg KH <gregkh@linuxfoundation.org>
To: Enguerrand de Ribaucourt
<enguerrand.de-ribaucourt@savoirfairelinux.com>
Cc: stable <stable@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v3] net: dp83822: disable rx error interrupt
Date: Fri, 16 Sep 2022 11:35:09 +0200 [thread overview]
Message-ID: <YyRDTT22caLQWaDg@kroah.com> (raw)
In-Reply-To: <1021996164.282624.1663139220592.JavaMail.zimbra@savoirfairelinux.com>
On Wed, Sep 14, 2022 at 03:07:00AM -0400, Enguerrand de Ribaucourt wrote:
> > From: "Greg KH" <gregkh@linuxfoundation.org>
> > To: "Enguerrand de Ribaucourt" <enguerrand.de-ribaucourt@savoirfairelinux.com>
> > Cc: "stable" <stable@vger.kernel.org>, "Andrew Lunn" <andrew@lunn.ch>, "Jakub Kicinski" <kuba@kernel.org>
> > Sent: Tuesday, September 13, 2022 1:30:26 PM
> > Subject: Re: [PATCH v3] net: dp83822: disable rx error interrupt
>
> > On Tue, Sep 13, 2022 at 10:17:48AM +0200, Enguerrand de Ribaucourt wrote:
> > > Some RX errors, notably when disconnecting the cable, increase the RCSR
> > > register. Once half full (0x7fff), an interrupt flood is generated. I
> > > measured ~3k/s interrupts even after the RX errors transfer was
> > > stopped.
>
> > > Since we don't read and clear the RCSR register, we should disable this
> > > interrupt.
>
> > > Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
> >> Signed-off-by: Enguerrand de Ribaucourt
> > > <enguerrand.de-ribaucourt@savoirfairelinux.com>
> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > > [backport of 5.10 commit 0e597e2affb90d6ea48df6890d882924acf71e19]
>
> > Backport to what? This is already in 5.10, where do you want this
> > commit applied to?
>
> > thanks,
>
> > greg k-h
>
> Hi,
>
> I would like this commit to be applied to 5.4. It should also apply to 4.19.
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2022-09-16 9:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 10:45 [PATCH v3 0/2] net: dp83822: backport fix interrupt floods Enguerrand de Ribaucourt
2022-09-07 10:45 ` [PATCH v3 1/2] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
2022-09-07 10:45 ` [PATCH v3 2/2] net: dp83822: disable rx error interrupt Enguerrand de Ribaucourt
2022-09-08 17:09 ` Greg KH
2022-09-12 10:07 ` Enguerrand de Ribaucourt
2022-09-12 14:39 ` Greg KH
2022-09-13 8:17 ` [PATCH v3] " Enguerrand de Ribaucourt
2022-09-13 11:30 ` Greg KH
2022-09-14 7:07 ` Enguerrand de Ribaucourt
2022-09-16 9:35 ` Greg KH [this message]
2022-09-08 17:07 ` [PATCH v3 0/2] net: dp83822: backport fix interrupt floods Greg KH
2022-09-12 10:02 ` Enguerrand de Ribaucourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyRDTT22caLQWaDg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=enguerrand.de-ribaucourt@savoirfairelinux.com \
--cc=kuba@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox