stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jiri Olsa <olsajiri@gmail.com>,
	stable@vger.kernel.org, bpf@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
	Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH stable 5.15 0/2] kbuild: Fix compilation for latest pahole release
Date: Mon, 19 Sep 2022 00:14:40 +0200	[thread overview]
Message-ID: <YyeYUEHyR/nHM8NT@krava> (raw)
In-Reply-To: <Yxc3Er1sv17xrei1@kroah.com>

On Tue, Sep 06, 2022 at 02:03:30PM +0200, Greg KH wrote:
> On Mon, Sep 05, 2022 at 09:04:10AM +0200, Jiri Olsa wrote:
> > On Sun, Sep 04, 2022 at 04:10:09PM +0200, Greg KH wrote:
> > > On Sun, Sep 04, 2022 at 03:18:59PM +0200, Jiri Olsa wrote:
> > > > hi,
> > > > new version of pahole (1.24) is causing compilation fail for 5.15
> > > > stable kernel, discussed in here [1][2]. Sending fix for that plus
> > > > one dependency patch.
> > > > 
> > > > Note for patch 1:
> > > > there was one extra line change in scripts/pahole-flags.sh file in
> > > > its linux tree merge commit:
> > > > 
> > > >   fc02cb2b37fe Merge tag 'net-next-for-5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
> > > > 
> > > > not sure how/if to track that, I squashed the change in.
> > > 
> > > Squashing is fine, thanks.
> > > 
> > > And do we also need this for kernels older than 5.15?  Like 5.10 and 5.4?
> > 
> > yes, 5.10 needs similar patchset, but this for 5.15 won't apply there,
> > so I'll send it separately
> > 
> > 5.4 passes compilation, but I don't think it will boot properly, still
> > need to check on that
> > 
> > in any case, more patches are coming ;-)
> 
> Ok, these two are now queued up, feel free to send the rest when you
> have them ready.

hi,
as for 5.10 changes, I have them ready, pushed in here:
  git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git pahole_fix_5_10

but it looks like CONFIG_DEBUG_INFO_BTF is not being used in 5.10,
because I had to backport other similar option, that would break
the build even earlier (--skip_encoding_btf_vars), or people use
just old pahole ;-)

I suggest we wait with this change until somebody actually wants
this fixed, AFAICS there's no report of broken 5.10 build yet

thanks,
jirka

  reply	other threads:[~2022-09-18 22:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-04 13:18 [PATCH stable 5.15 0/2] kbuild: Fix compilation for latest pahole release Jiri Olsa
2022-09-04 13:19 ` [PATCH stable 5.15 1/2] kbuild: Unify options for BTF generation for vmlinux and modules Jiri Olsa
2022-09-04 13:19 ` [PATCH stable 5.15 2/2] kbuild: Add skip_encoding_btf_enum64 option to pahole Jiri Olsa
2022-09-04 13:20   ` kernel test robot
2022-09-04 14:09     ` Greg KH
2022-09-04 14:10 ` [PATCH stable 5.15 0/2] kbuild: Fix compilation for latest pahole release Greg KH
2022-09-05  7:04   ` Jiri Olsa
2022-09-06 12:03     ` Greg KH
2022-09-18 22:14       ` Jiri Olsa [this message]
2022-10-17 18:02         ` Nathan Chancellor
2022-10-17 21:27           ` Jiri Olsa
2022-10-18  6:45             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyeYUEHyR/nHM8NT@krava \
    --to=olsajiri@gmail.com \
    --cc=acme@kernel.org \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=yakoyoku@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).