public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Sean Young <sean@mess.org>,
	linux-media@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, Oliver Neukum <oneukum@suse.com>,
	stable@vger.kernel.org, Dongliang Mu <mudongliangabcd@gmail.com>
Subject: Re: [PATCH RESEND] media: flexcop-usb: fix endpoint type check
Date: Thu, 22 Sep 2022 11:37:36 +0200	[thread overview]
Message-ID: <Yyws4Pd4bAl3iq2e@hovoldconsulting.com> (raw)
In-Reply-To: <YywfxwBmdmvQ0i21@kroah.com>

On Thu, Sep 22, 2022 at 10:41:43AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 20, 2022 at 11:00:35AM +0200, Johan Hovold wrote:
> > Mauro and Hans,
> > 
> > On Mon, Aug 22, 2022 at 05:10:27PM +0200, Johan Hovold wrote:
> > > Commit d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint
> > > type") tried to add an endpoint type sanity check for the single
> > > isochronous endpoint but instead broke the driver by checking the wrong
> > > descriptor or random data beyond the last endpoint descriptor.
> > > 
> > > Make sure to check the right endpoint descriptor.
> > > 
> > > Fixes: d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type")
> > > Cc: Oliver Neukum <oneukum@suse.com>
> > > Cc: stable@vger.kernel.org	# 5.9
> > > Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > ---
> > > 
> > > It's been two months and two completely ignored reminders so resending.
> > > 
> > > Can someone please pick this fix up and let me know when that has been
> > > done?
> > 
> > It's been another month so sending yet another reminder. This driver as
> > been broken since 5.9 and I posted this fix almost four months ago and
> > have sent multiple reminders since.
> > 
> > Can someone please pick this one and the follow-up cleanups up?
> 
> I've taken this one in my tree now.  Which one were the "follow-up"
> cleanups?

Thanks. These are the follow-up cleanups:

	https://lore.kernel.org/lkml/20220822151456.27178-1-johan@kernel.org/

Perhaps we should start taking USB related changes like this through the
USB tree by default. Posting patches to the media subsystem feels like
shooting patches at a black hole.

Johan

  reply	other threads:[~2022-09-22  9:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 15:10 [PATCH RESEND] media: flexcop-usb: fix endpoint type check Johan Hovold
2022-09-20  9:00 ` Johan Hovold
2022-09-22  8:41   ` Greg Kroah-Hartman
2022-09-22  9:37     ` Johan Hovold [this message]
2022-09-22 10:12       ` Greg Kroah-Hartman
2022-09-22 10:39         ` Sean Young
2022-09-22 10:43           ` Greg Kroah-Hartman
2022-09-26  8:59         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yyws4Pd4bAl3iq2e@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mudongliangabcd@gmail.com \
    --cc=oneukum@suse.com \
    --cc=sean@mess.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox