[PATCH v2] mailbox: zynqmp: setup IPI for each valid child node

[PATCH v2] mailbox: zynqmp: setup IPI for each valid child node

[Tanmay Shah]

As per zynqmp-ipi bindings, zynqmp IPI node can have multiple child nodes.
Current IPI setup function is set only for first child node. If IPI node
has multiple child nodes in the device-tree, then IPI setup fails for
child nodes other than first child node. In such case kernel will crash.
Fix this crash by registering IPI setup function for each available child
node.

Cc: stable@vger.kernel.org
Fixes: 41bcf30100c5 (mailbox: zynqmp: Move buffered IPI setup)
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
Reviewed-by: Michal Simek <michal.simek@amd.com>
---

Changes in v2:
  - Add Fixes tag

 drivers/mailbox/zynqmp-ipi-mailbox.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index 521d08b9ab47..815e0492f029 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -940,10 +940,10 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
 	pdata->num_mboxes = num_mboxes;
 
 	mbox = pdata->ipi_mboxes;
-	mbox->setup_ipi_fn = ipi_fn;
-
 	for_each_available_child_of_node(np, nc) {
 		mbox->pdata = pdata;
+		mbox->setup_ipi_fn = ipi_fn;
+
 		ret = zynqmp_ipi_mbox_probe(mbox, nc);
 		if (ret) {
 			of_node_put(nc);

base-commit: 28955f4fa2823e39f1ecfb3a37a364563527afbc
-- 
2.34.1

Re: [PATCH v2] mailbox: zynqmp: setup IPI for each valid child node

[Sasha Levin]

[ Sasha's backport helper bot ]

Hi,

Found matching upstream commit: 98fc87fe2937db5a4948c553f69b5a3cc94c230a


Status in newer kernel trees:
6.12.y | Not found

Note: The patch differs from the upstream commit:
---
1:  98fc87fe2937 ! 1:  7d2de1d13592 mailbox: zynqmp: setup IPI for each valid child node
    @@ Commit message
         Fix this crash by registering IPI setup function for each available child
         node.
     
    +    Cc: stable@vger.kernel.org
    +    Fixes: 41bcf30100c5 (mailbox: zynqmp: Move buffered IPI setup)
         Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
    -    Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
    +    Reviewed-by: Michal Simek <michal.simek@amd.com>
     
      ## drivers/mailbox/zynqmp-ipi-mailbox.c ##
     @@ drivers/mailbox/zynqmp-ipi-mailbox.c: static int zynqmp_ipi_probe(struct platform_device *pdev)
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.12.y       |  Success    |  Success   |
| stable/linux-6.6.y        |  Failed     |  N/A       |
| stable/linux-6.1.y        |  Failed     |  N/A       |
| stable/linux-5.15.y       |  Failed     |  N/A       |
| stable/linux-5.10.y       |  Failed     |  N/A       |
| stable/linux-5.4.y        |  Failed     |  N/A       |

Re: [PATCH v2] mailbox: zynqmp: setup IPI for each valid child node

[Sasha Levin]

On Mon, Dec 16, 2024 at 07:42:17PM -0500, Sasha Levin wrote:
>[ Sasha's backport helper bot ]
>
>Hi,
>
>Found matching upstream commit: 98fc87fe2937db5a4948c553f69b5a3cc94c230a
>
>
>Status in newer kernel trees:
>6.12.y | Not found
>
>Note: The patch differs from the upstream commit:
>---
>1:  98fc87fe2937 ! 1:  7d2de1d13592 mailbox: zynqmp: setup IPI for each valid child node
>    @@ Commit message
>         Fix this crash by registering IPI setup function for each available child
>         node.
>
>    +    Cc: stable@vger.kernel.org
>    +    Fixes: 41bcf30100c5 (mailbox: zynqmp: Move buffered IPI setup)
>         Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>    -    Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
>    +    Reviewed-by: Michal Simek <michal.simek@amd.com>

Why did we lose a S-O-B line here?

-- 
Thanks,
Sasha

Re: [PATCH v2] mailbox: zynqmp: setup IPI for each valid child node

[Tanmay Shah]

On 12/18/24 3:59 PM, Sasha Levin wrote:
> On Mon, Dec 16, 2024 at 07:42:17PM -0500, Sasha Levin wrote:
>> [ Sasha's backport helper bot ]
>>
>> Hi,
>>
>> Found matching upstream commit: 98fc87fe2937db5a4948c553f69b5a3cc94c230a
>>
>>
>> Status in newer kernel trees:
>> 6.12.y | Not found
>>
>> Note: The patch differs from the upstream commit:
>> ---
>> 1:  98fc87fe2937 ! 1:  7d2de1d13592 mailbox: zynqmp: setup IPI for 
>> each valid child node
>>    @@ Commit message
>>         Fix this crash by registering IPI setup function for each 
>> available child
>>         node.
>>
>>    +    Cc: stable@vger.kernel.org
>>    +    Fixes: 41bcf30100c5 (mailbox: zynqmp: Move buffered IPI setup)
>>         Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>>    -    Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
>>    +    Reviewed-by: Michal Simek <michal.simek@amd.com>
> 
> Why did we lose a S-O-B line here?
> 

I added manually RB line as per ask from last review.
May be I misunderstood something.
How to fix it ?

Can I add S-O-B line and RB line both manually ?