From: Sasha Levin <sashal@kernel.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: stable@vger.kernel.org, Dan Carpenter <dan.carpenter@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH 6.12.y] dmaengine: loongson2-apb: Change GENMASK to GENMASK_ULL
Date: Sun, 29 Dec 2024 22:18:48 -0500 [thread overview]
Message-ID: <Z3IRGGQ0iqya5jnA@lappy> (raw)
In-Reply-To: <20241230013919.1086511-1-zhoubinbin@loongson.cn>
On Mon, Dec 30, 2024 at 09:39:19AM +0800, Binbin Zhou wrote:
>Fix the following smatch static checker warning:
>
>drivers/dma/loongson2-apb-dma.c:189 ls2x_dma_write_cmd()
>warn: was expecting a 64 bit value instead of '~(((0)) + (((~((0))) - (((1)) << (0)) + 1) & (~((0)) >> ((8 * 4) - 1 - (4)))))'
>
>The GENMASK macro used "unsigned long", which caused build issues when
>using a 32-bit toolchain because it would try to access bits > 31. This
>patch switches GENMASK to GENMASK_ULL, which uses "unsigned long long".
>
>Fixes: 71e7d3cb6e55 ("dmaengine: ls2x-apb: New driver for the Loongson LS2X APB DMA controller")
>Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
>Closes: https://lore.kernel.org/all/87cdc025-7246-4548-85ca-3d36fdc2be2d@stanley.mountain/
>Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
>Link: https://lore.kernel.org/r/20241028093413.1145820-1-zhoubinbin@loongson.cn
>Signed-off-by: Vinod Koul <vkoul@kernel.org>
>(cherry picked from commit 4b65d5322e1d8994acfdb9b867aa00bdb30d177b)
I'll queue it up, but please read
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-3
--
Thanks,
Sasha
next prev parent reply other threads:[~2024-12-30 3:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 16:02 FAILED: patch "[PATCH] dmaengine: loongson2-apb: Change GENMASK to GENMASK_ULL" failed to apply to 6.12-stable tree gregkh
2024-12-30 1:39 ` [PATCH 6.12.y] dmaengine: loongson2-apb: Change GENMASK to GENMASK_ULL Binbin Zhou
2024-12-30 3:04 ` Sasha Levin
2024-12-30 3:18 ` Sasha Levin [this message]
2024-12-30 3:27 ` 周彬彬
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3IRGGQ0iqya5jnA@lappy \
--to=sashal@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox