From: Ivan Kokshaysky <ink@unseen.parts>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Richard Henderson <richard.henderson@linaro.org>,
Matt Turner <mattst88@gmail.com>, Oleg Nesterov <oleg@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
"Paul E. McKenney" <paulmck@kernel.org>,
Magnus Lindholm <linmag7@gmail.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/4] alpha/uapi: do not expose kernel-only stack frame structures
Date: Mon, 3 Feb 2025 18:13:55 +0100 [thread overview]
Message-ID: <Z6D5UyV9Z0demt40@minute> (raw)
In-Reply-To: <alpine.DEB.2.21.2502020051280.41663@angie.orcam.me.uk>
On Sun, Feb 02, 2025 at 05:39:52PM +0000, Maciej W. Rozycki wrote:
> What do you think about providing arch/alpha/include/asm/bpf_perf_event.h
> instead with either a dummy definition of `bpf_user_pt_regs_t', or perhaps
> one typedef'd to `struct sigcontext' (as it seems to provide all that's
> needed), and then reverting to v1 of arch/alpha/include/uapi/asm/ptrace.h
> (and then just copying the contents of arch/alpha/include/asm/ftrace.h
> over rather than leaving all the useless CPP stuff in) so that we don't
> have useless `struct pt_regs' exported at all?
Probably that's the right thing to do. However, it implies adding
#elif defined(__alpha__)
#include "../../arch/alpha/include/uapi/asm/bpf_perf_event.h"
in tools/include/uapi/asm/bpf_perf_event.h. I'm afraid that will
result in too many loosely related changes for this patch series.
I'm starting to think that the best way for the time being is to keep
uapi/asm/ptrace.h and apply the fix there (i.e. revert to v0 patch
posted on linux-alpha). And mention the pt_regs vs uapi issue in the
commit message, of course, to deal with it later. Your opinion?
Ivan.
next prev parent reply other threads:[~2025-02-03 17:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 10:41 [PATCH v2 0/4] alpha: stack fixes Ivan Kokshaysky
2025-01-31 10:41 ` [PATCH v2 1/4] alpha/uapi: do not expose kernel-only stack frame structures Ivan Kokshaysky
2025-02-02 17:39 ` Maciej W. Rozycki
2025-02-03 17:13 ` Ivan Kokshaysky [this message]
2025-02-04 13:42 ` Maciej W. Rozycki
2025-02-03 11:01 ` John Paul Adrian Glaubitz
2025-01-31 10:41 ` [PATCH v2 2/4] alpha: replace hardcoded stack offsets with autogenerated ones Ivan Kokshaysky
2025-02-02 17:40 ` Maciej W. Rozycki
2025-01-31 10:41 ` [PATCH v2 3/4] alpha: make stack 16-byte aligned (most cases) Ivan Kokshaysky
2025-02-02 17:41 ` Maciej W. Rozycki
2025-01-31 10:41 ` [PATCH v2 4/4] alpha: align stack for page fault and user unaligned trap handlers Ivan Kokshaysky
2025-02-02 17:41 ` Maciej W. Rozycki
2025-02-01 9:46 ` [PATCH v2 0/4] alpha: stack fixes John Paul Adrian Glaubitz
2025-02-01 23:12 ` Michael Cree
2025-02-02 9:43 ` Magnus Lindholm
2025-02-02 18:13 ` Michael Cree
2025-02-03 11:05 ` John Paul Adrian Glaubitz
2025-02-02 17:37 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6D5UyV9Z0demt40@minute \
--to=ink@unseen.parts \
--cc=arnd@arndb.de \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=mattst88@gmail.com \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=richard.henderson@linaro.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox