From: Ido Schimmel <idosch@idosch.org>
To: Eric Dumazet <edumazet@google.com>, nicolas.dichtel@6wind.com
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: advertise 'netns local' property via netlink
Date: Thu, 6 Feb 2025 19:11:50 +0200 [thread overview]
Message-ID: <Z6TtVlfe8XiWLyVB@shredder> (raw)
In-Reply-To: <CANn89iJO66n0OtC1axnkfukm=vD5AacHcuxXh3sUvyTXdSy-TQ@mail.gmail.com>
On Thu, Feb 06, 2025 at 05:59:03PM +0100, Eric Dumazet wrote:
> On Thu, Feb 6, 2025 at 5:51 PM Nicolas Dichtel
> > @@ -2229,6 +2231,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
> > [IFLA_ALLMULTI] = { .type = NLA_REJECT },
> > [IFLA_GSO_IPV4_MAX_SIZE] = NLA_POLICY_MIN(NLA_U32, MAX_TCP_HEADER + 1),
> > [IFLA_GRO_IPV4_MAX_SIZE] = { .type = NLA_U32 },
> > + [IFLA_NETNS_LOCAL] = { .type = NLA_U8 },
>
> As this is a read-only attribute, I would suggest NLA_REJECT
And please update the spec:
Documentation/netlink/specs/rt_link.yaml
next prev parent reply other threads:[~2025-02-06 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250206165132.2898347-1-nicolas.dichtel@6wind.com>
2025-02-06 16:50 ` [PATCH net 1/2] net: advertise 'netns local' property via netlink Nicolas Dichtel
2025-02-06 16:59 ` Eric Dumazet
2025-02-06 17:11 ` Ido Schimmel [this message]
2025-02-06 23:39 ` Jakub Kicinski
2025-02-07 9:10 ` Nicolas Dichtel
2025-02-07 19:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6TtVlfe8XiWLyVB@shredder \
--to=idosch@idosch.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox