regression on 6.1.129-rc with perf

regression on 6.1.129-rc with perf

[Max Krummenacher]

Our CI built linux-stable-rc.git queue/6.1 at commit eef4a8a45ba1
("btrfs: output the reason for open_ctree() failure").
(built for arm and arm64, albeit I don't think it matters.)

Building perf produced 2 build errors which I wanted to report
even before the RC1 is out.

| ...tools/perf/util/namespaces.c:247:27: error: invalid type argument of '->' (have 'int')
|   247 |         RC_CHK_ACCESS(nsi)->in_pidns = true;  
|       |                           ^~

introduced by commit 93520bacf784 ("perf namespaces: Introduce
nsinfo__set_in_pidns()"). The RC_CK_ACCSS macro was introduced in 6.4.
Removing the macro made this go away ( nsi->in_pidns = true; ).


Second perf build error:
| ld: ...tools/perf/util/machine.c:1176: undefined reference to `kallsyms__get_symbol_start'

Introduced by commits:
710c2e913aa9 perf machine: Don't ignore _etext when not a text symbol
69a87a32f5cd perf machine: Include data symbols in the kernel map

These two use the function kallsyms__get_symbol_start added with:
f9dd531c5b82 perf symbols: Add kallsyms__get_symbol_start()
So f9dd531c5b82 would additionally be needed.


The kernel itself built fine, due to the perf error we don't have runtime
testresults.

Best regards
Max

Re: regression on 6.1.129-rc with perf

[Greg Kroah-Hartman]

On Mon, Feb 17, 2025 at 04:23:26PM +0100, Max Krummenacher wrote:
> Our CI built linux-stable-rc.git queue/6.1 at commit eef4a8a45ba1
> ("btrfs: output the reason for open_ctree() failure").
> (built for arm and arm64, albeit I don't think it matters.)
> 
> Building perf produced 2 build errors which I wanted to report
> even before the RC1 is out.
> 
> | ...tools/perf/util/namespaces.c:247:27: error: invalid type argument of '->' (have 'int')
> |   247 |         RC_CHK_ACCESS(nsi)->in_pidns = true;  
> |       |                           ^~
> 
> introduced by commit 93520bacf784 ("perf namespaces: Introduce
> nsinfo__set_in_pidns()"). The RC_CK_ACCSS macro was introduced in 6.4.
> Removing the macro made this go away ( nsi->in_pidns = true; ).
> 
> 
> Second perf build error:
> | ld: ...tools/perf/util/machine.c:1176: undefined reference to `kallsyms__get_symbol_start'
> 
> Introduced by commits:
> 710c2e913aa9 perf machine: Don't ignore _etext when not a text symbol
> 69a87a32f5cd perf machine: Include data symbols in the kernel map
> 
> These two use the function kallsyms__get_symbol_start added with:
> f9dd531c5b82 perf symbols: Add kallsyms__get_symbol_start()
> So f9dd531c5b82 would additionally be needed.
> 
> 
> The kernel itself built fine, due to the perf error we don't have runtime
> testresults.

Thanks for letting me know, I'll go drop those patches from the queues
now.  Dealing with perf issues on older kernels like this really isn't
needed.

thanks,

greg k-h