stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] ARM: dts: imx6qdl-apalis: Fix poweroff on Apalis iMX6
@ 2025-01-10 15:18 Stefan Eichenberger
  2025-02-18  9:52 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Eichenberger @ 2025-01-10 15:18 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	max.krummenacher, francesco.dolcini
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel,
	Stefan Eichenberger, stable

From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

The current solution for powering off the Apalis iMX6 is not functioning
as intended. To resolve this, it is necessary to power off the
vgen2_reg, which will also set the POWER_ENABLE_MOCI signal to a low
state. This ensures the carrier board is properly informed to initiate
its power-off sequence.

The new solution uses the regulator-poweroff driver, which will power
off the regulator during a system shutdown.

CC: stable@vger.kernel.org
Fixes: 4eb56e26f92e ("ARM: dts: imx6q-apalis: Command pmic to standby for poweroff")
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
index 1c72da417011..614b65821995 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
@@ -108,6 +108,11 @@ lvds_panel_in: endpoint {
 		};
 	};
 
+	poweroff {
+		compatible = "regulator-poweroff";
+		cpu-supply = <&vgen2_reg>;
+	};
+
 	reg_module_3v3: regulator-module-3v3 {
 		compatible = "regulator-fixed";
 		regulator-always-on;
@@ -236,10 +241,6 @@ &can2 {
 	status = "disabled";
 };
 
-&clks {
-	fsl,pmic-stby-poweroff;
-};
-
 /* Apalis SPI1 */
 &ecspi1 {
 	cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>;
@@ -527,7 +528,6 @@ &i2c2 {
 
 	pmic: pmic@8 {
 		compatible = "fsl,pfuze100";
-		fsl,pmic-stby-poweroff;
 		reg = <0x08>;
 
 		regulators {
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] ARM: dts: imx6qdl-apalis: Fix poweroff on Apalis iMX6
  2025-01-10 15:18 [PATCH v1] ARM: dts: imx6qdl-apalis: Fix poweroff on Apalis iMX6 Stefan Eichenberger
@ 2025-02-18  9:52 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2025-02-18  9:52 UTC (permalink / raw)
  To: Stefan Eichenberger
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	max.krummenacher, francesco.dolcini, devicetree, imx,
	linux-arm-kernel, linux-kernel, Stefan Eichenberger, stable

On Fri, Jan 10, 2025 at 04:18:29PM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> The current solution for powering off the Apalis iMX6 is not functioning
> as intended. To resolve this, it is necessary to power off the
> vgen2_reg, which will also set the POWER_ENABLE_MOCI signal to a low
> state. This ensures the carrier board is properly informed to initiate
> its power-off sequence.
> 
> The new solution uses the regulator-poweroff driver, which will power
> off the regulator during a system shutdown.
> 
> CC: stable@vger.kernel.org
> Fixes: 4eb56e26f92e ("ARM: dts: imx6q-apalis: Command pmic to standby for poweroff")
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-18  9:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-10 15:18 [PATCH v1] ARM: dts: imx6qdl-apalis: Fix poweroff on Apalis iMX6 Stefan Eichenberger
2025-02-18  9:52 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).