* Re: Patch "alpha: make stack 16-byte aligned (most cases)" has been added to the 6.6-stable tree [not found] <2025021844-cruelness-freedom-e051@gregkh> @ 2025-02-18 13:40 ` Ivan Kokshaysky 2025-02-18 14:04 ` Greg KH 0 siblings, 1 reply; 5+ messages in thread From: Ivan Kokshaysky @ 2025-02-18 13:40 UTC (permalink / raw) To: gregkh; +Cc: linmag7, macro, mattst88, stable On Tue, Feb 18, 2025 at 01:55:45PM +0100, gregkh@linuxfoundation.org wrote: > > This is a note to let you know that I've just added the patch titled > > alpha: make stack 16-byte aligned (most cases) Hi Greg, thanks for applying this! > Patches currently in stable-queue which might be from ink@unseen.parts are > > queue-6.6/alpha-make-stack-16-byte-aligned-most-cases.patch > queue-6.6/alpha-align-stack-for-page-fault-and-user-unaligned-trap-handlers.patch The third one (commit 77b823fa619f97d alpha: replace hardcoded stack offsets with autogenerated ones) is also needed, but it won't apply as-is to 6.6 and older kernels. Do you want me to provide the patches? Ivan. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch "alpha: make stack 16-byte aligned (most cases)" has been added to the 6.6-stable tree 2025-02-18 13:40 ` Patch "alpha: make stack 16-byte aligned (most cases)" has been added to the 6.6-stable tree Ivan Kokshaysky @ 2025-02-18 14:04 ` Greg KH 2025-02-18 14:50 ` [PATCH][v4.19-v6.1] alpha: replace hardcoded stack offsets with autogenerated Ivan Kokshaysky 2025-02-18 14:52 ` [PATCH][v6.6.x] alpha: replace hardcoded stack offsets with autogenerated ones Ivan Kokshaysky 0 siblings, 2 replies; 5+ messages in thread From: Greg KH @ 2025-02-18 14:04 UTC (permalink / raw) To: Ivan Kokshaysky; +Cc: linmag7, macro, mattst88, stable On Tue, Feb 18, 2025 at 02:40:38PM +0100, Ivan Kokshaysky wrote: > On Tue, Feb 18, 2025 at 01:55:45PM +0100, gregkh@linuxfoundation.org wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > alpha: make stack 16-byte aligned (most cases) > > Hi Greg, thanks for applying this! > > > Patches currently in stable-queue which might be from ink@unseen.parts are > > > > queue-6.6/alpha-make-stack-16-byte-aligned-most-cases.patch > > queue-6.6/alpha-align-stack-for-page-fault-and-user-unaligned-trap-handlers.patch > > The third one (commit 77b823fa619f97d alpha: replace hardcoded stack offsets > with autogenerated ones) is also needed, but it won't apply as-is to 6.6 > and older kernels. > > Do you want me to provide the patches? Please do! thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH][v4.19-v6.1] alpha: replace hardcoded stack offsets with autogenerated 2025-02-18 14:04 ` Greg KH @ 2025-02-18 14:50 ` Ivan Kokshaysky 2025-02-18 14:52 ` [PATCH][v6.6.x] alpha: replace hardcoded stack offsets with autogenerated ones Ivan Kokshaysky 1 sibling, 0 replies; 5+ messages in thread From: Ivan Kokshaysky @ 2025-02-18 14:50 UTC (permalink / raw) To: Greg KH; +Cc: linmag7, macro, mattst88, stable [backported commit 77b823fa619f97d16409] This allows the assembly in entry.S to automatically keep in sync with changes in the stack layout (struct pt_regs and struct switch_stack). Cc: stable@vger.kernel.org # v4.19.x-v6.1.x Signed-off-by: Ivan Kokshaysky <ink@unseen.parts> --- arch/alpha/kernel/asm-offsets.c | 4 ++++ arch/alpha/kernel/entry.S | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/alpha/kernel/asm-offsets.c b/arch/alpha/kernel/asm-offsets.c index 4cfeae42c79a..e9dad60b147f 100644 --- a/arch/alpha/kernel/asm-offsets.c +++ b/arch/alpha/kernel/asm-offsets.c @@ -32,7 +32,9 @@ void foo(void) DEFINE(CRED_EGID, offsetof(struct cred, egid)); BLANK(); + DEFINE(SP_OFF, offsetof(struct pt_regs, ps)); DEFINE(SIZEOF_PT_REGS, sizeof(struct pt_regs)); + DEFINE(SWITCH_STACK_SIZE, sizeof(struct switch_stack)); DEFINE(PT_PTRACED, PT_PTRACED); DEFINE(CLONE_VM, CLONE_VM); DEFINE(CLONE_UNTRACED, CLONE_UNTRACED); diff --git a/arch/alpha/kernel/entry.S b/arch/alpha/kernel/entry.S index dd26062d75b3..6fb38365539d 100644 --- a/arch/alpha/kernel/entry.S +++ b/arch/alpha/kernel/entry.S @@ -15,10 +15,6 @@ .set noat .cfi_sections .debug_frame -/* Stack offsets. */ -#define SP_OFF 184 -#define SWITCH_STACK_SIZE 320 - .macro CFI_START_OSF_FRAME func .align 4 .globl \func -- 2.47.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH][v6.6.x] alpha: replace hardcoded stack offsets with autogenerated ones 2025-02-18 14:04 ` Greg KH 2025-02-18 14:50 ` [PATCH][v4.19-v6.1] alpha: replace hardcoded stack offsets with autogenerated Ivan Kokshaysky @ 2025-02-18 14:52 ` Ivan Kokshaysky 2025-02-18 15:12 ` Greg KH 1 sibling, 1 reply; 5+ messages in thread From: Ivan Kokshaysky @ 2025-02-18 14:52 UTC (permalink / raw) To: Greg KH; +Cc: linmag7, macro, mattst88, stable [backported commit 77b823fa619f97d16409] This allows the assembly in entry.S to automatically keep in sync with changes in the stack layout (struct pt_regs and struct switch_stack). Cc: stable@vger.kernel.org # v6.6.x Signed-off-by: Ivan Kokshaysky <ink@unseen.parts> --- arch/alpha/kernel/asm-offsets.c | 4 ++++ arch/alpha/kernel/entry.S | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/alpha/kernel/asm-offsets.c b/arch/alpha/kernel/asm-offsets.c index 4cfeae42c79a..e9dad60b147f 100644 --- a/arch/alpha/kernel/asm-offsets.c +++ b/arch/alpha/kernel/asm-offsets.c @@ -34,7 +34,9 @@ void foo(void) DEFINE(CRED_EGID, offsetof(struct cred, egid)); BLANK(); + DEFINE(SP_OFF, offsetof(struct pt_regs, ps)); DEFINE(SIZEOF_PT_REGS, sizeof(struct pt_regs)); + DEFINE(SWITCH_STACK_SIZE, sizeof(struct switch_stack)); DEFINE(PT_PTRACED, PT_PTRACED); DEFINE(CLONE_VM, CLONE_VM); DEFINE(CLONE_UNTRACED, CLONE_UNTRACED); diff --git a/arch/alpha/kernel/entry.S b/arch/alpha/kernel/entry.S index dd26062d75b3..6fb38365539d 100644 --- a/arch/alpha/kernel/entry.S +++ b/arch/alpha/kernel/entry.S @@ -15,10 +15,6 @@ .set noat .cfi_sections .debug_frame -/* Stack offsets. */ -#define SP_OFF 184 -#define SWITCH_STACK_SIZE 64 - .macro CFI_START_OSF_FRAME func .align 4 .globl \func -- 2.47.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][v6.6.x] alpha: replace hardcoded stack offsets with autogenerated ones 2025-02-18 14:52 ` [PATCH][v6.6.x] alpha: replace hardcoded stack offsets with autogenerated ones Ivan Kokshaysky @ 2025-02-18 15:12 ` Greg KH 0 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2025-02-18 15:12 UTC (permalink / raw) To: Ivan Kokshaysky; +Cc: linmag7, macro, mattst88, stable On Tue, Feb 18, 2025 at 03:52:20PM +0100, Ivan Kokshaysky wrote: > [backported commit 77b823fa619f97d16409] Nit, please use the full commit id. > > This allows the assembly in entry.S to automatically keep in sync with > changes in the stack layout (struct pt_regs and struct switch_stack). > > Cc: stable@vger.kernel.org # v6.6.x > Signed-off-by: Ivan Kokshaysky <ink@unseen.parts> Also you dropped all the other signed-off-by here. I'll go fix this up... thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-18 15:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2025021844-cruelness-freedom-e051@gregkh>
2025-02-18 13:40 ` Patch "alpha: make stack 16-byte aligned (most cases)" has been added to the 6.6-stable tree Ivan Kokshaysky
2025-02-18 14:04 ` Greg KH
2025-02-18 14:50 ` [PATCH][v4.19-v6.1] alpha: replace hardcoded stack offsets with autogenerated Ivan Kokshaysky
2025-02-18 14:52 ` [PATCH][v6.6.x] alpha: replace hardcoded stack offsets with autogenerated ones Ivan Kokshaysky
2025-02-18 15:12 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).