public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Salvatore Bonaccorso <carnil@debian.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: stable <stable@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>, Martin Wilck <mwilck@suse.com>,
	Christoph Hellwig <hch@infradead.org>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	"Linux regression tracking (Thorsten Leemhuis)" 
	<regressions@leemhuis.info>
Subject: Re: Please apply commit 06e472acf964 ("scsi: mpt3sas: Remove usage of dma_get_required_mask() API") to stable series
Date: Wed, 8 Mar 2023 17:32:19 +0100	[thread overview]
Message-ID: <ZAi4k/09acWV0wRZ@eldamar.lan> (raw)
In-Reply-To: <yq1356hnzd2.fsf@ca-mkp.ca.oracle.com>

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

hi Martin, hi Sreekanth,

On Mon, Mar 06, 2023 at 08:16:35PM -0500, Martin K. Petersen wrote:
> 
> Hi Salvatore!
> 
> > Sreekanth and Martin is this still on your radar?
> 
> Broadcom will have to provide a suitable fix for the relevant older
> stable releases. It is the patch author's responsibility to provide
> backports.
> 
> > as 9df650963bf6 picking as well is not an option.
> 
> Why not?

Thanks to Martin Wilck from SUSE to get me understanding the picture.
The problem is that e0e0747de0ea ("scsi: mpt3sas:
Fix return value check of dma_get_required_mask()") was backported to
several series. In mainline though the mis-merge did undo that. So I
believe the right thing would be to revert first in the stable series
where it was applied (5.10.y, 5.15.y) the commit e0e0747de0ea ("scsi:
mpt3sas: Fix return value check of dma_get_required_mask()")  and then
on top of this revert apply the patches:

9df650963bf6 ("scsi: mpt3sas: Don't change DMA mask while reallocating pools")
1a2dcbdde82e ("scsi: mpt3sas: re-do lost mpt3sas DMA mask fix")
06e472acf964 ("scsi: mpt3sas: Remove usage of dma_get_required_mask() API")

Attached mbox file implements this.

Does that looks now good for resolving the regression?

Regards,
Salvatore

[-- Attachment #2: mpt3sas-xen-regression.mbox --]
[-- Type: application/mbox, Size: 8128 bytes --]

  reply	other threads:[~2023-03-08 16:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-04  9:52 Please apply commit 06e472acf964 ("scsi: mpt3sas: Remove usage of dma_get_required_mask() API") to stable series Salvatore Bonaccorso
2023-03-06  7:21 ` Greg Kroah-Hartman
2023-03-06 20:53   ` Salvatore Bonaccorso
2023-03-07  1:16 ` Martin K. Petersen
2023-03-08 16:32   ` Salvatore Bonaccorso [this message]
2023-03-08 18:06     ` Martin Wilck
2023-03-08 19:33       ` Salvatore Bonaccorso
2023-03-10 12:53         ` Greg Kroah-Hartman
2023-03-08 19:05     ` Martin K. Petersen
2023-03-09  9:45       ` Salvatore Bonaccorso
2023-03-09 15:51         ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAi4k/09acWV0wRZ@eldamar.lan \
    --to=carnil@debian.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=mwilck@suse.com \
    --cc=regressions@leemhuis.info \
    --cc=sashal@kernel.org \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox