From: Greg KH <gregkh@linuxfoundation.org>
To: "Seth Forshee (DigitalOcean)" <sforshee@kernel.org>
Cc: brauner@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 6.2] filelocks: use mount idmapping for setlease permission check
Date: Wed, 15 Mar 2023 08:46:41 +0100 [thread overview]
Message-ID: <ZBF34S96xlmOpb61@kroah.com> (raw)
In-Reply-To: <20230313192140.3986664-1-sforshee@kernel.org>
On Mon, Mar 13, 2023 at 02:21:40PM -0500, Seth Forshee (DigitalOcean) wrote:
> From: Seth Forshee <sforshee@kernel.org>
>
> [ Upstream commit 42d0c4bdf753063b6eec55415003184d3ca24f6e ]
>
> A user should be allowed to take out a lease via an idmapped mount if
> the fsuid matches the mapped uid of the inode. generic_setlease() is
> checking the unmapped inode uid, causing these operations to be denied.
>
> Fix this by comparing against the mapped inode uid instead of the
> unmapped uid.
>
> Fixes: 9caccd41541a ("fs: introduce MOUNT_ATTR_IDMAP")
> Cc: stable@vger.kernel.org
> Signed-off-by: Seth Forshee (DigitalOcean) <sforshee@kernel.org>
> Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
> ---
> fs/locks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-03-15 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 10:53 FAILED: patch "[PATCH] filelocks: use mount idmapping for setlease permission check" failed to apply to 6.2-stable tree gregkh
2023-03-13 19:21 ` [PATCH 6.2] filelocks: use mount idmapping for setlease permission check Seth Forshee (DigitalOcean)
2023-03-15 7:46 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBF34S96xlmOpb61@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=brauner@kernel.org \
--cc=sforshee@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).