Re: stable-rc/linux-5.10.y bisection: baseline.login on hp-x360-14-G1-sona

Re: stable-rc/linux-5.10.y bisection: baseline.login on hp-x360-14-G1-sona

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 7074 bytes --]

On Tue, Mar 21, 2023 at 05:18:03AM -0700, KernelCI bot wrote:

The KernelCI bisection bot found a boot bisection on one of the HP
ChromeBooks in v5.10.175 triggered by b5005605013d ("drm/i915: Don't use
BAR mappings for ring buffers with LLC").  The system appears to die
very early in boot with no output.

I've left the full report from the bot below, including links to full
boot logs such as they are and a tag for the bot, and the full web
dashboard for the test case fail is at:

    https://linux.kernelci.org/test/plan/id/64147346939869e04b8c8694/

including details of the successful test on v5.10.174.

> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> * This automated bisection report was sent to you on the basis  *
> * that you may be involved with the breaking commit it has      *
> * found.  No manual investigation has been done to verify it,   *
> * and the root cause of the problem may be somewhere else.      *
> *                                                               *
> * If you do send a fix, please include this trailer:            *
> *   Reported-by: "kernelci.org bot" <bot@kernelci.org>          *
> *                                                               *
> * Hope this helps!                                              *
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> 
> stable-rc/linux-5.10.y bisection: baseline.login on hp-x360-14-G1-sona
> 
> Summary:
>   Start:      de26e1b2103b Linux 5.10.175
>   Plain log:  https://storage.kernelci.org/stable-rc/linux-5.10.y/v5.10.175/x86_64/x86_64_defconfig+x86-chromebook/gcc-10/lab-collabora/baseline-hp-x360-14-G1-sona.txt
>   HTML log:   https://storage.kernelci.org/stable-rc/linux-5.10.y/v5.10.175/x86_64/x86_64_defconfig+x86-chromebook/gcc-10/lab-collabora/baseline-hp-x360-14-G1-sona.html
>   Result:     b5005605013d drm/i915: Don't use BAR mappings for ring buffers with LLC
> 
> Checks:
>   revert:     PASS
>   verify:     PASS
> 
> Parameters:
>   Tree:       stable-rc
>   URL:        https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>   Branch:     linux-5.10.y
>   Target:     hp-x360-14-G1-sona
>   CPU arch:   x86_64
>   Lab:        lab-collabora
>   Compiler:   gcc-10
>   Config:     x86_64_defconfig+x86-chromebook
>   Test case:  baseline.login
> 
> Breaking commit found:
> 
> -------------------------------------------------------------------------------
> commit b5005605013d30ab27c303cbaeff60b7872234a3
> Author: John Harrison <John.C.Harrison@Intel.com>
> Date:   Wed Feb 15 17:11:01 2023 -0800
> 
>     drm/i915: Don't use BAR mappings for ring buffers with LLC
>     
>     commit 85636167e3206c3fbd52254fc432991cc4e90194 upstream.
>     
>     Direction from hardware is that ring buffers should never be mapped
>     via the BAR on systems with LLC. There are too many caching pitfalls
>     due to the way BAR accesses are routed. So it is safest to just not
>     use it.
>     
>     Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>     Fixes: 9d80841ea4c9 ("drm/i915: Allow ringbuffers to be bound anywhere")
>     Cc: Chris Wilson <chris@chris-wilson.co.uk>
>     Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>     Cc: Jani Nikula <jani.nikula@linux.intel.com>
>     Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>     Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>     Cc: intel-gfx@lists.freedesktop.org
>     Cc: <stable@vger.kernel.org> # v4.9+
>     Tested-by: Jouni Högander <jouni.hogander@intel.com>
>     Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>     Link: https://patchwork.freedesktop.org/patch/msgid/20230216011101.1909009-3-John.C.Harrison@Intel.com
>     (cherry picked from commit 65c08339db1ada87afd6cfe7db8e60bb4851d919)
>     Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>     Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c
> index 4034a4bac7f0..69b2e5509d67 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ring.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ring.c
> @@ -49,7 +49,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww)
>  	if (unlikely(ret))
>  		goto err_unpin;
>  
> -	if (i915_vma_is_map_and_fenceable(vma))
> +	if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915))
>  		addr = (void __force *)i915_vma_pin_iomap(vma);
>  	else
>  		addr = i915_gem_object_pin_map(vma->obj,
> @@ -91,7 +91,7 @@ void intel_ring_unpin(struct intel_ring *ring)
>  		return;
>  
>  	i915_vma_unset_ggtt_write(vma);
> -	if (i915_vma_is_map_and_fenceable(vma))
> +	if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915))
>  		i915_vma_unpin_iomap(vma);
>  	else
>  		i915_gem_object_unpin_map(vma->obj);
> -------------------------------------------------------------------------------
> 
> 
> Git bisection log:
> 
> -------------------------------------------------------------------------------
> git bisect start
> # good: [955623617f2f505ac08d0efda2bb50c1a52e2c96] Linux 5.10.174
> git bisect good 955623617f2f505ac08d0efda2bb50c1a52e2c96
> # bad: [de26e1b2103b1f56451f6ad77f0190c9066c87dc] Linux 5.10.175
> git bisect bad de26e1b2103b1f56451f6ad77f0190c9066c87dc
> # good: [d16701a385b54f44bf41ff1d7485e7a11080deb3] bnxt_en: Avoid order-5 memory allocation for TPA data
> git bisect good d16701a385b54f44bf41ff1d7485e7a11080deb3
> # good: [d47d364f6671d8794a89e4972b1fd3284d213c96] macintosh: windfarm: Use unsigned type for 1-bit bitfields
> git bisect good d47d364f6671d8794a89e4972b1fd3284d213c96
> # bad: [c3fd717b58f0a3e2461c16e2360ee6a949b47940] ext4: add strict range checks while freeing blocks
> git bisect bad c3fd717b58f0a3e2461c16e2360ee6a949b47940
> # good: [7aa5a495cbf8a33cd9fec892c180dedf14292b76] ipmi/watchdog: replace atomic_add() and atomic_sub()
> git bisect good 7aa5a495cbf8a33cd9fec892c180dedf14292b76
> # bad: [b5005605013d30ab27c303cbaeff60b7872234a3] drm/i915: Don't use BAR mappings for ring buffers with LLC
> git bisect bad b5005605013d30ab27c303cbaeff60b7872234a3
> # good: [c53d50d8081a49ba21f866a51277a012b9efad8e] skbuff: Fix nfct leak on napi stolen
> git bisect good c53d50d8081a49ba21f866a51277a012b9efad8e
> # first bad commit: [b5005605013d30ab27c303cbaeff60b7872234a3] drm/i915: Don't use BAR mappings for ring buffers with LLC
> -------------------------------------------------------------------------------
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#39748): https://groups.io/g/kernelci-results/message/39748
> Mute This Topic: https://groups.io/mt/97753328/1131744
> Group Owner: kernelci-results+owner@groups.io
> Unsubscribe: https://groups.io/g/kernelci-results/unsub [broonie@kernel.org]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: stable-rc/linux-5.10.y bisection: baseline.login on hp-x360-14-G1-sona

[Greg Kroah-Hartman]

On Tue, Mar 21, 2023 at 12:58:22PM +0000, Mark Brown wrote:
> On Tue, Mar 21, 2023 at 05:18:03AM -0700, KernelCI bot wrote:
> 
> The KernelCI bisection bot found a boot bisection on one of the HP
> ChromeBooks in v5.10.175 triggered by b5005605013d ("drm/i915: Don't use
> BAR mappings for ring buffers with LLC").  The system appears to die
> very early in boot with no output.

Should be fixed in the 5.10-rc that is out for review right now.

thanks,

greg k-h