Re: [PATCH 5.15/5.10 1/1] NFSD: fix use-after-free in __nfs42_ssc_open()

[Greg KH <greg@kroah.com>]

On Tue, Mar 28, 2023 at 04:47:59PM +0300, Ovidiu Panait wrote:
> From: Dai Ngo <dai.ngo@oracle.com>
> 
> commit 75333d48f92256a0dec91dbf07835e804fc411c0 upstream.
> 
> Problem caused by source's vfsmount being unmounted but remains
> on the delayed unmount list. This happens when nfs42_ssc_open()
> return errors.
> 
> Fixed by removing nfsd4_interssc_connect(), leave the vfsmount
> for the laundromat to unmount when idle time expires.
> 
> We don't need to call nfs_do_sb_deactive when nfs42_ssc_open
> return errors since the file was not opened so nfs_server->active
> was not incremented. Same as in nfsd4_copy, if we fail to
> launch nfsd4_do_async_copy thread then there's no need to
> call nfs_do_sb_deactive
> 
> Reported-by: Xingyuan Mo <hdthky0@gmail.com>
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> Tested-by: Xingyuan Mo <hdthky0@gmail.com>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
> ---
>  fs/nfsd/nfs4proc.c | 22 ++++++----------------
>  1 file changed, 6 insertions(+), 16 deletions(-)
> 

Now queued up, thanks.

greg k-h