From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D158C761A6 for ; Tue, 4 Apr 2023 15:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235015AbjDDPTf (ORCPT ); Tue, 4 Apr 2023 11:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232696AbjDDPTe (ORCPT ); Tue, 4 Apr 2023 11:19:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FDBD3A9F for ; Tue, 4 Apr 2023 08:19:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1BDCD634E7 for ; Tue, 4 Apr 2023 15:19:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 518C4C433D2; Tue, 4 Apr 2023 15:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680621572; bh=nuJTFJGIsbVfytQ1dEZ5dUc8pyR/VtbceXSR+Jw9H/o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pI6KF+KDRQ9n3cMnn/xrHPLrP0Os6RSDqn2lmDfyr9Ndcq7n8+zKJ0dDL0YXDi7Y6 BzlCBvAkfi155dBSzxUGdM1bin88pzkTOud6fecYJBuOqvFVvTrC2uXPBhYdvL73XT /u6NxgGVXyD3EhBOO/Wo8wP0CUq3RjENVkFvAhJLMvqqWRe2CFCNm4ow724VAxQs1Z 5lIdWTNHAHWQeHlFwaHu6vavXPeR5tUekKdpBBX1RgcnnpKjhsFbRQ9xk0FHQWnB6f jABq6ATNRK1SI0laDAEuJ/goKp/K0jotbpDUSIO1saSBvAyJgGVT91yb6JgQLLatYo MJZpVoPnEEvdA== Date: Tue, 4 Apr 2023 11:19:30 -0400 From: Sasha Levin To: Pascal Ernster Cc: Ming Lei , Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, Christoph Hellwig , Keith Busch , Chao Leng , Sagi Grimberg , Hannes Reinecke , Chaitanya Kulkarni , Jens Axboe Subject: Re: [PATCH 6.1 021/181] blk-mq: move the srcu_struct used for quiescing to the tagset Message-ID: References: <20230403140415.090615502@linuxfoundation.org> <20230403140415.825266522@linuxfoundation.org> <401a5df3-b13b-fb56-a305-9c82f5f0ca77@0.smtp.remotehost.it> <2f2bcc75-e46b-6849-734c-2e646d9bb382@0.smtp.remotehost.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2f2bcc75-e46b-6849-734c-2e646d9bb382@0.smtp.remotehost.it> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 04, 2023 at 07:56:10AM +0200, Pascal Ernster wrote: >[2023-04-04 03:17] Ming Lei: >>On Mon, Apr 03, 2023 at 11:06:53PM +0200, Pascal Ernster wrote: >>>On systems with their (btrfs) root filesystem residing on an LVM volume, >>>this patch is reproducibly causing a complete freeze during shutdowns and >>>reboots. >>> >>>I had previously replied with the same message to patch 022/181 instead of >>>this one, but had gotten the subject mixed up actually meant this patch. >> >>That is because the dependency patch is missed: >> >>commit 8537380bb988 ("blk-mq: skip non-mq queues in blk_mq_quiesce_queue") >> >>https://lore.kernel.org/linux-block/Y6qpwYaPOxgsZjp9@T590/ > > >Thanks a lot Ming, this does indeed fix the issue for me. :) Perfect, thanks for the report and the fix. I've dropped these two patches from the 6.1 tree for now with plans to re-do it along with the missing dependency for the next release. -- Thanks, Sasha