From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013DAC77B7C for ; Thu, 11 May 2023 23:39:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239514AbjEKXj2 (ORCPT ); Thu, 11 May 2023 19:39:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238953AbjEKXj1 (ORCPT ); Thu, 11 May 2023 19:39:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD6C1B3 for ; Thu, 11 May 2023 16:39:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4A0C9652A4 for ; Thu, 11 May 2023 23:39:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFB4FC433EF; Thu, 11 May 2023 23:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683848365; bh=Gv5MfhydX+49jiZzdsRRXtDqpEBgMyuFb+CambfuEgw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WlyBUMXJ5U8ucF0yUrps0uElu/wpeLWSctmlsnq2FA8UfHJnL6tHxG28AjI6/Ktyw DW38TJRoQRtmcizvqX/kU9Pc7ukF2OU096a7HJVcFN9uzLH54TMTP4qEHSqG7d438W OJuThv6BnUlBIOmBMb8Tko+Hzu5CmklK8t0L1L4WoScJ3GV9+Xli6myQsYHDkfx7Of LpLzhbBkhaGUVyywI5y6n1M+AiwtoGgP41b0mCwx5dHLgaVIKpgwdMRGHddyC+Em6h 5UY41OOZPZDwRjZtoKWKyDTbGNdTlxtqRKdTvXfyl17udrLnuiuXMigLFzXZBJLBqT eJx4FvSUdCL9g== Date: Thu, 11 May 2023 19:39:25 -0400 From: Sasha Levin To: Conor Dooley Cc: stable@vger.kernel.org, Conor Dooley , palmer@dabbelt.com, Guenter Roeck Subject: Re: [PATCH 6.1 v1] RISC-V: fix lock splat in riscv_cpufeature_patch_func() Message-ID: References: <20230509-suspend-labrador-3eb6f0a8ac77@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20230509-suspend-labrador-3eb6f0a8ac77@spud> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, May 09, 2023 at 10:36:42PM +0100, Conor Dooley wrote: >From: Conor Dooley > >Guenter reported a lockdep splat that appears to have been present for a >while in v6.1.y & the backports of the riscv_patch_in_stop_machine dance >did nothing to help here, as the lock is not being taken when >patch_text_nosync() is called in riscv_cpufeature_patch_func(). >Add the lock/unlock; elide the splat. Is this not a problem upstream? -- Thanks, Sasha