From: Petr Mladek <pmladek@suse.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: "Greg KH" <greg@kroah.com>,
stable@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Mel Gorman" <mgorman@techsingularity.net>,
"Michal Hocko" <mhocko@suse.com>,
"Patrick Daly" <quic_pdaly@quicinc.com>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Steven Rostedt" <rostedt@goodmis.org>
Subject: Re: [PATCH 4.14.y] mm/page_alloc: fix potential deadlock on zonelist_update_seq seqlock
Date: Tue, 9 May 2023 10:55:49 +0200 [thread overview]
Message-ID: <ZFoKlZARGm1GPPLK@alley> (raw)
In-Reply-To: <c9738f09-b2a2-a8a0-ebee-ba4a3563f475@I-love.SAKURA.ne.jp>
On Mon 2023-05-08 19:06:59, Tetsuo Handa wrote:
> On 2023/05/08 15:56, Greg KH wrote:
> > On Sun, May 07, 2023 at 11:56:29PM +0900, Tetsuo Handa wrote:
> >> commit 1007843a91909a4995ee78a538f62d8665705b66 upstream.
> >
> > For obvious reasons, we can't just apply this to 4.14.y. Please provide
> > fixes for all other stable trees as well so that you do not have a
> > regression when updating to a newer kernel.
> >
> > I'll drop this from my review queue for now and wait for all of the
> > backported versions.
>
> 5.15+ stable kernels already have the upstream patch applied.
>
> Only 4.14/4.19/5.4/5.10 stable kernels failed to apply the upstream patch
> due to the need to append include/linux/printk.h part. I want to hear
> whether Petr Mladek is happy with this partial printk.h backport
> ( https://lkml.kernel.org/r/ZC0298t3o6+TyASH@alley ) before I spam
> everyone with the same change for 4.19/5.4/5.10.
The partial backport of the printk_deferred_enter/exit definitions
looks fine to me.
I am just not sure what is the preferred way of adding this to
stable trees.
Tetsuo merged the partial backport with the mm fix.
Alternative solution would be to add the partial backport
as a separate patch. Anyway, the commit message should mention
the original commit 85e3e7fbbb720b9897f ("printk: remove
NMI tracking").
Best Regards,
Petr
next prev parent reply other threads:[~2023-05-09 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 7:05 FAILED: patch "[PATCH] mm/page_alloc: fix potential deadlock on zonelist_update_seq" failed to apply to 4.14-stable tree gregkh
2023-05-07 14:56 ` [PATCH 4.14.y] mm/page_alloc: fix potential deadlock on zonelist_update_seq seqlock Tetsuo Handa
2023-05-08 6:56 ` Greg KH
2023-05-08 10:06 ` Tetsuo Handa
2023-05-09 8:55 ` Petr Mladek [this message]
2023-05-14 4:41 ` [PATCH 4.14.y] printk: declare printk_deferred_{enter,safe}() in include/linux/printk.h Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFoKlZARGm1GPPLK@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=greg@kroah.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=quic_pdaly@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox