From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A4BC7EE2D for ; Fri, 26 May 2023 10:44:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242330AbjEZKoL (ORCPT ); Fri, 26 May 2023 06:44:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbjEZKoK (ORCPT ); Fri, 26 May 2023 06:44:10 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E11A0F7 for ; Fri, 26 May 2023 03:44:07 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f60b3f32b4so4097025e9.1 for ; Fri, 26 May 2023 03:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1685097846; x=1687689846; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qsQxO8IPaN8nlkq2Xhl3/vTTB1iuV7FAGBCEMX0YyP4=; b=a/Dxr0an09yn6eTERfXRH+v8faaaU6lJpIpaMVdr8uhHgGPIFcSHLjgyJP0Vs9vG3X CI7CvyUojqeAfJkJ6DzM8lVf+D7nruedj2h/O4/cJ6MP1iQEUxZcP/SUtjVxubwB+PHl OkrRiXzOYbQahNp6wZsjc944QrRWhl9c1yRa+ptE0DNk6jCj+mqRbAh8NRGdWajyTcQv /nMjWZzEDwCU3H/txJSK6o3Zb8IMhF9k44d3DYWlpn7OGbptrtAlsPOKp/PDH+zBorEI FLlQmIKKJOViWnURGXVbGY5pCbOmioounsv+72zQR/DZ5qTYnzkibGOGV2pUPmbH/HzF JnVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685097846; x=1687689846; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qsQxO8IPaN8nlkq2Xhl3/vTTB1iuV7FAGBCEMX0YyP4=; b=QYQkJ5MCg5VbNm23PBsfiu05Y8bNRZDVsH/jWecSIqcIgV/obMuFn7a9Dgbb+oVMy1 +TkLzEBln7EwnsvhIEhqWvaM1dUmhOx9UW+1OjMVRPAY+aVLIVjGtZTy0td46yYI/i7Q HwRKMy2WuWM8U7qmUukxxkK0TEWliL9+x9abojIS5s0vjlBVCD4gt0RDPdqJgJK+UDUf RWbz9PZDUmmnQKdkUTVV/wT0LiK874VRtJjZ9iVtlIqHb1JcFkZ7VlKubcpCPARkNTwh Ct7rN2tqGK4ID+EFpgZq9wMPnIVycAHyvDnkb7gGM8lpSHOAmrm9BVFLSvSt7mPWx4dE Mdyg== X-Gm-Message-State: AC+VfDz9oEuDSckaCGn8LWaF36rj20plZPJgObZ0BZ/DH2OuNC+bqqCs XGzakAyoMGEXVHVpCVOztezOPg== X-Google-Smtp-Source: ACHHUZ7L0BkNcRhWjehagPKWH/0YUPeR2EChh9bPq+mRlKo9vIF2GGsqEqyEcn8B+nVasosRFerNoA== X-Received: by 2002:a05:600c:2196:b0:3f6:3da:1603 with SMTP id e22-20020a05600c219600b003f603da1603mr1158694wme.26.1685097846338; Fri, 26 May 2023 03:44:06 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id s26-20020a7bc39a000000b003f42328b5d9sm4792425wmj.39.2023.05.26.03.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 03:44:05 -0700 (PDT) Date: Fri, 26 May 2023 12:44:04 +0200 From: Jiri Pirko To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, decui@microsoft.com, kys@microsoft.com, paulros@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net, wei.liu@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, leon@kernel.org, longli@microsoft.com, ssengar@linux.microsoft.com, linux-rdma@vger.kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, bpf@vger.kernel.org, ast@kernel.org, sharmaajay@microsoft.com, hawk@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net: mana: Fix perf regression: remove rx_cqes, tx_cqes counters Message-ID: References: <1684963320-25282-1-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1684963320-25282-1-git-send-email-haiyangz@microsoft.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Wed, May 24, 2023 at 11:22:00PM CEST, haiyangz@microsoft.com wrote: >The apc->eth_stats.rx_cqes is one per NIC (vport), and it's on the >frequent and parallel code path of all queues. So, r/w into this >single shared variable by many threads on different CPUs creates a >lot caching and memory overhead, hence perf regression. And, it's >not accurate due to the high volume concurrent r/w. > >Since the error path of mana_poll_rx_cq() already has warnings, so >keeping the counter and convert it to a per-queue variable is not >necessary. So, just remove this counter from this high frequency >code path. > >Also, remove the tx_cqes counter for the same reason. We have >warnings & other counters for errors on that path, and don't need >to count every normal cqe processing. > >Cc: stable@vger.kernel.org >Fixes: bd7fc6e1957c ("net: mana: Add new MANA VF performance counters for easier troubleshooting") >Signed-off-by: Haiyang Zhang Reviewed-by: Jiri Pirko