stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Janne Huttunen (Nokia)" <janne.huttunen@nokia.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: IPMI related kernel panics since v4.19.286
Date: Mon, 19 Jun 2023 08:32:59 -0500	[thread overview]
Message-ID: <ZJBZCxyRTPsuGQ0l@mail.minyard.net> (raw)
In-Reply-To: <2023061927-fox-constrict-1918@gregkh>

On Mon, Jun 19, 2023 at 02:23:47PM +0200, Greg KH wrote:
> On Mon, Jun 19, 2023 at 11:11:16AM +0000, Janne Huttunen (Nokia) wrote:
> > 
> > We recently updated an internal test server from kernel v4.19.273
> > to v4.19.286 and since then it has already multiple times triggered
> > a kernel panic due to a hard lockup. The lockups look e.g. like
> > this:
> 
> Does this also happen on newer 5.4 and 6.4-rc7 releases?

If I am correct, no, it will not happen there.  I was surprised 

I believe the change that causes this issue was:

  b4a34aa6d "ipmi: Fix how the lower layers are told to watch for messages"

which was backported into 4.9.  But there was a locking change:

  e1891cffd4c4 "ipmi: Make the smi watcher be disabled immediately when not needed"

that came in 5.1.  That was required for b4a34aa6d to work correctly,
and I didn't realize that.  If Janne tests that patch (and the other fix
for it), then kernels 5.1 and later are good as they are.

Thanks,

-corey

> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2023-06-19 13:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 11:11 IPMI related kernel panics since v4.19.286 Janne Huttunen (Nokia)
2023-06-19 12:23 ` Greg KH
2023-06-19 13:32   ` Corey Minyard [this message]
2023-06-19 12:52 ` Corey Minyard
2023-06-20  9:56   ` Janne Huttunen (Nokia)
2023-06-20 11:54     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJBZCxyRTPsuGQ0l@mail.minyard.net \
    --to=minyard@acm.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=janne.huttunen@nokia.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).