* [PATCH] power: supply: rk817: Add missing module alias
@ 2023-06-12 14:36 Nicolas Frattaroli
2023-06-27 17:39 ` Chris Morgan
2023-09-14 16:03 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Frattaroli @ 2023-06-12 14:36 UTC (permalink / raw)
To: Sebastian Reichel, Maya Matuszczyk, Lee Jones, Chris Morgan
Cc: Nicolas Frattaroli, linux-rockchip, stable, Sebastian Reichel,
linux-pm, linux-kernel
Similar to the rk817 codec alias that was missing, the rk817 charger
driver is missing a module alias as well. This absence prevents the
driver from autoprobing on OF systems when it is built as a module.
Add the right MODULE_ALIAS to fix this.
Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
Cc: stable@vger.kernel.org
Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
---
drivers/power/supply/rk817_charger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
index 1a2143641e66..76b991e112da 100644
--- a/drivers/power/supply/rk817_charger.c
+++ b/drivers/power/supply/rk817_charger.c
@@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
MODULE_AUTHOR("Maya Matuszczyk <maccraft123mc@gmail.com>");
MODULE_AUTHOR("Chris Morgan <macromorgan@hotmail.com>");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:rk817-charger");
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: rk817: Add missing module alias
2023-06-12 14:36 [PATCH] power: supply: rk817: Add missing module alias Nicolas Frattaroli
@ 2023-06-27 17:39 ` Chris Morgan
2023-09-14 16:03 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Chris Morgan @ 2023-06-27 17:39 UTC (permalink / raw)
To: Nicolas Frattaroli
Cc: Sebastian Reichel, Maya Matuszczyk, Lee Jones, Chris Morgan,
linux-rockchip, stable, Sebastian Reichel, linux-pm, linux-kernel
On Mon, Jun 12, 2023 at 04:36:52PM +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
>
> Add the right MODULE_ALIAS to fix this.
>
Good catch, thank you.
Reviewed-by: Chris Morgan <macromorgan@hotmail.com>
> Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
> drivers/power/supply/rk817_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> index 1a2143641e66..76b991e112da 100644
> --- a/drivers/power/supply/rk817_charger.c
> +++ b/drivers/power/supply/rk817_charger.c
> @@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
> MODULE_AUTHOR("Maya Matuszczyk <maccraft123mc@gmail.com>");
> MODULE_AUTHOR("Chris Morgan <macromorgan@hotmail.com>");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:rk817-charger");
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: rk817: Add missing module alias
2023-06-12 14:36 [PATCH] power: supply: rk817: Add missing module alias Nicolas Frattaroli
2023-06-27 17:39 ` Chris Morgan
@ 2023-09-14 16:03 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2023-09-14 16:03 UTC (permalink / raw)
To: Sebastian Reichel, Maya Matuszczyk, Lee Jones, Chris Morgan,
Nicolas Frattaroli
Cc: linux-rockchip, stable, linux-pm, linux-kernel
On Mon, 12 Jun 2023 16:36:52 +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
>
> Add the right MODULE_ALIAS to fix this.
>
>
> [...]
Applied, thanks!
[1/1] power: supply: rk817: Add missing module alias
commit: cbcdfbf5a6cd66e47e5ee5d49c4c5a27a07ba082
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-14 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-12 14:36 [PATCH] power: supply: rk817: Add missing module alias Nicolas Frattaroli
2023-06-27 17:39 ` Chris Morgan
2023-09-14 16:03 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).