From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C15EE3F27 for ; Mon, 11 Sep 2023 20:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236303AbjIKUvQ (ORCPT ); Mon, 11 Sep 2023 16:51:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242003AbjIKPUQ (ORCPT ); Mon, 11 Sep 2023 11:20:16 -0400 X-Greylist: delayed 81684 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 11 Sep 2023 08:20:11 PDT Received: from MTA-06-4.privateemail.com (mta-06-4.privateemail.com [198.54.122.146]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50689FA; Mon, 11 Sep 2023 08:20:11 -0700 (PDT) Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id 2A7EB18000A4; Mon, 11 Sep 2023 11:20:10 -0400 (EDT) Received: from [192.168.2.177] (bras-base-toroon4332w-grc-39-74-12-11-94.dsl.bell.ca [74.12.11.94]) by mta-06.privateemail.com (Postfix) with ESMTPA; Mon, 11 Sep 2023 11:19:55 -0400 (EDT) Date: Mon, 11 Sep 2023 11:19:47 -0400 From: Hamza Mahfooz Subject: Re: [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's receivers To: Hans de Goede Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org, Greg Kroah-Hartman , Alan Stern , Benjamin Tissoires , Bastien Nocera , =?iso-8859-2?q?=A3ukasz?= Bartosik , Nicolas Dumazet , Jean-Francois Le Fillatre , Mark Pearson , Hannu Hartikainen , linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <9d2dff10-5a3b-b24a-c3d8-3c843891966d@redhat.com> References: <20230910163751.4210-1-someguy@effective-light.com> <9d2dff10-5a3b-b24a-c3d8-3c843891966d@redhat.com> X-Mailer: geary/44.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hey Hans, On Mon, Sep 11 2023 at 09:32:42 AM +02:00:00, Hans de Goede wrote: > Hi Hamza, > > On 9/10/23 18:37, Hamza Mahfooz wrote: >> This device causes the system to wake up from suspend, as soon as it >> enters it (even if the device attached to the receiver is powered >> off). >> So, ignore remote wakeup events from it. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Hamza Mahfooz >> --- >> drivers/usb/core/quirks.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c >> index 15e9bd180a1d..d2e2a2873f34 100644 >> --- a/drivers/usb/core/quirks.c >> +++ b/drivers/usb/core/quirks.c >> @@ -264,6 +264,10 @@ static const struct usb_device_id >> usb_quirk_list[] = { >> /* Logitech Harmony 700-series */ >> { USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT >> }, >> >> + /* Logitech lightspeed receiver (0xc547) */ >> + { USB_DEVICE(0x046d, 0xc547), .driver_info = >> + USB_QUIRK_IGNORE_REMOTE_WAKEUP }, >> + >> /* Philips PSC805 audio device */ >> { USB_DEVICE(0x0471, 0x0155), .driver_info = >> USB_QUIRK_RESET_RESUME }, >> > > If this is a lightspeed receiver then it really should be handled by > hid-logitech-dj.c unless this new receiver is using a new protocol ? > > I wonder if adding it there also fixes the remote > wakeup issue (I doubt it fixes it but worth a try) ? Seems like the following series does indeed fix this issue: https://lore.kernel.org/linux-input/20230716182320.85483-1-mavchatz@protonmail.com/T/#u > > Regards, > > Hans > > >