From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 667CACA0EC6 for ; Mon, 11 Sep 2023 22:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377580AbjIKW1W (ORCPT ); Mon, 11 Sep 2023 18:27:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241907AbjIKPRc (ORCPT ); Mon, 11 Sep 2023 11:17:32 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B1D0FA for ; Mon, 11 Sep 2023 08:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694445448; x=1725981448; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ASb+8XEdlEfkRTlJdZ6yt2r85II0MjsJzw3iRvMOw6k=; b=UOWro4BSCBIXu1VLV6+QR2VgFPLgF2UOsovAVYEVJAY5iKsnov+z8vJS vvJBgTLsDXGj24JmMiXWNpeMWPvstQJZ9FbdOuZM3rEbYRJVOthVR/N0x QoQQtxW8VhXzlI62W7BjJ9XWDA9YdxZ7xoX4OrGvU6fn6XIHFURCAFzga 4I7CSh10iTyzV9yEDJ44tUhTdlWIYyi5m4bQh2imzZ08hrf/bbqSNrdBB JxU7QUUCMP5OnS6+tJ0ODzx3hMTydJk0IGuY+Jh+tuu36WH6kOkU2OxRC bSJtTLhYwEXtqs/ilqZyGttW/CjFyNG19BcAIRhtW2gQgP8msor6ToJqN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="377021422" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="377021422" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 08:17:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="693127933" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="693127933" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.153]) by orsmga003.jf.intel.com with SMTP; 11 Sep 2023 08:17:25 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 11 Sep 2023 18:17:24 +0300 Date: Mon, 11 Sep 2023 18:17:24 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Coelho, Luciano" Cc: "intel-gfx@lists.freedesktop.org" , "stable@vger.kernel.org" Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Only check eDP HPD when AUX CH is shared Message-ID: References: <20230907121736.23734-1-ville.syrjala@linux.intel.com> <20230908052527.685-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Sep 11, 2023 at 08:19:21AM +0000, Coelho, Luciano wrote: > On Fri, 2023-09-08 at 08:25 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Apparently Acer Chromebook C740 (BDW-ULT) doesn't have the > > eDP HPD line properly connected, and thus fails the new > > HPD check during eDP probe. The result is that we lose the > > eDP output. > > > > I suspect all such machines would all be Chromebooks or other > > Small duplication here "...all such machines would all...". Dropped one 'all'. Thanks for the review -> pushed. > > > > Linux exclusive systems as the Windows driver likely wouldn't > > work either. I did check a few other BDW machines here and > > those do have eDP HPD connected, one of them even is a > > different Chromebook (Samus). > > > > To account for these funky machines let's skip the HPD check when > > it looks like the eDP port is the only one using that specific AUX > > channel. In case of multiple ports sharing the same AUX CH (eg. on > > Asrock B250M-HDV) we still do the check and thus should correctly > > ignore the eDP port in favor of the other DP port (usually a DP->VGA > > converter). > > > > v2: Don't oops during list iteration > > > > Cc: stable@vger.kernel.org > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9264 > > Fixes: cfe5bdfb27fa ("drm/i915: Check HPD live state during eDP probe") > > Signed-off-by: Ville Syrjälä > > --- > > Regardless of the small grammatical issue, LGTM: > > Reviewed-by: Luca Coelho > > -- > Cheers, > Luca. -- Ville Syrjälä Intel