stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Jack Wang <jinpu.wang@ionos.com>
Cc: x86@kernel.org, Jarkko Sakkinen <jarkko@kernel.org>,
	Haitao Huang <haitao.huang@linux.intel.com>,
	stable@vger.kernel.org, Yu Zhang <yu.zhang@ionos.com>,
	Kai Huang <kai.huang@intel.com>
Subject: Re: [PATCHv4] x86/sgx: Avoid softlockup from sgx_vepc_release
Date: Wed, 6 Sep 2023 23:57:01 +0200	[thread overview]
Message-ID: <ZPj1rWuZdSyL5X1M@gmail.com> (raw)
In-Reply-To: <20230906131712.143629-1-jinpu.wang@ionos.com>


* Jack Wang <jinpu.wang@ionos.com> wrote:

> We hit softlocup with following call trace:
> 
> ? asm_sysvec_apic_timer_interrupt+0x16/0x20
> xa_erase+0x21/0xb0
> ? sgx_free_epc_page+0x20/0x50
> sgx_vepc_release+0x75/0x220
> __fput+0x89/0x250
> task_work_run+0x59/0x90
> do_exit+0x337/0x9a0
> 
> Similar like commit 8795359e35bc ("x86/sgx: Silence softlockup detection
> when releasing large enclaves"). The test system has 64GB of enclave memory,
> and all assigned to a single VM. Release vepc take longer time and triggers
> the softlockup warning.
> 
> Add cond_resched() to give other tasks a chance to run and placate
> the softlockup detector.

I've rewritten the changelog: it's not just a change to 'placate' the 
softlockup detector, the SGX code was causing *real*, very long 
non-preemptible delays in the kernel. That's a real kernel bug, not some 
softlockup whingle that needs to be silenced ...

So what this patch does is to break up those delays & latencies, and that 
softlockup doesn't warn anymore is a side effect fix.

I've changed the description accordingly, and applied it to tip:x86/urgent.

Thanks,

	Ingo

      reply	other threads:[~2023-09-06 21:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 13:17 [PATCHv4] x86/sgx: Avoid softlockup from sgx_vepc_release Jack Wang
2023-09-06 21:57 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPj1rWuZdSyL5X1M@gmail.com \
    --to=mingo@kernel.org \
    --cc=haitao.huang@linux.intel.com \
    --cc=jarkko@kernel.org \
    --cc=jinpu.wang@ionos.com \
    --cc=kai.huang@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=x86@kernel.org \
    --cc=yu.zhang@ionos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).