From: Sasha Levin <sashal@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
anarsoul@gmail.com, tiny.windzz@gmail.com, rafael@kernel.org,
wens@csie.org, samuel@sholland.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH AUTOSEL 6.5 6/6] thermal/drivers/sun8i: Free calibration nvmem after reading it
Date: Mon, 18 Sep 2023 13:28:02 -0400 [thread overview]
Message-ID: <ZQiHrd0BH9f8OAQa@sashalap> (raw)
In-Reply-To: <ZPxm/xjvsI24JWkB@finisterre.sirena.org.uk>
On Sat, Sep 09, 2023 at 01:37:19PM +0100, Mark Brown wrote:
>On Fri, Sep 08, 2023 at 09:12:54PM -0400, Sasha Levin wrote:
>> From: Mark Brown <broonie@kernel.org>
>>
>> [ Upstream commit c51592a95f360aabf2b8a5691c550e1749dc41eb ]
>>
>> The sun8i thermal driver reads calibration data via the nvmem API at
>> startup, updating the device configuration and not referencing the data
>> again. Rather than explicitly freeing the nvmem data the driver relies
>> on devm_ to release it, even though the data is never referenced again.
>> The allocation is still tracked so it's not leaked but this is notable
>> when looking at the code and is a little wasteful so let's instead
>> explicitly free the nvmem after we're done with it.
>
>This is a minor cleanup which as with so much of what's come in today's
>backports seems very questionable for stable.
I'll drop this, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2023-09-18 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 1:12 [PATCH AUTOSEL 6.5 1/6] printk: Reduce console_unblank() usage in unsafe scenarios Sasha Levin
2023-09-09 1:12 ` [PATCH AUTOSEL 6.5 2/6] printk: Keep non-panic-CPUs out of console lock Sasha Levin
2023-09-09 1:12 ` [PATCH AUTOSEL 6.5 3/6] printk: Do not take console lock for console_flush_on_panic() Sasha Levin
2023-09-09 1:12 ` [PATCH AUTOSEL 6.5 4/6] printk: Consolidate console deferred printing Sasha Levin
2023-09-09 1:12 ` [PATCH AUTOSEL 6.5 5/6] printk: Rename abandon_console_lock_in_panic() to other_cpu_in_panic() Sasha Levin
2023-09-09 1:12 ` [PATCH AUTOSEL 6.5 6/6] thermal/drivers/sun8i: Free calibration nvmem after reading it Sasha Levin
2023-09-09 12:37 ` Mark Brown
2023-09-18 17:28 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQiHrd0BH9f8OAQa@sashalap \
--to=sashal@kernel.org \
--cc=anarsoul@gmail.com \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=samuel@sholland.org \
--cc=stable@vger.kernel.org \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).