From: Sasha Levin <sashal@kernel.org>
To: Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: stable@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
Rui Zhu <zhurui3@huawei.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH 6.5] iommu/arm-smmu-v3: Avoid constructing invalid range commands
Date: Fri, 6 Oct 2023 09:52:46 -0400 [thread overview]
Message-ID: <ZSARLoAx_mPkrG8f@sashalap> (raw)
In-Reply-To: <20231005193425.656925-1-eahariha@linux.microsoft.com>
On Thu, Oct 05, 2023 at 07:34:25PM +0000, Easwar Hariharan wrote:
>From: Robin Murphy <robin.murphy@arm.com>
>
>commit eb6c97647be227822c7ce23655482b05e348fba5 upstream
>
>Although io-pgtable's non-leaf invalidations are always for full tables,
>I missed that SVA also uses non-leaf invalidations, while being at the
>mercy of whatever range the MMU notifier throws at it. This means it
>definitely wants the previous TTL fix as well, since it also doesn't
>know exactly which leaf level(s) may need invalidating, but it can also
>give us less-aligned ranges wherein certain corners may lead to building
>an invalid command where TTL, Num and Scale are all 0. It should be fine
>to handle this by over-invalidating an extra page, since falling back to
>a non-range command opens up a whole can of errata-flavoured worms.
>
>Fixes: 6833b8f2e199 ("iommu/arm-smmu-v3: Set TTL invalidation hint better")
>Reported-by: Rui Zhu <zhurui3@huawei.com>
>Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>Link: https://lore.kernel.org/r/b99cfe71af2bd93a8a2930f20967fb2a4f7748dd.1694432734.git.robin.murphy@arm.com
>Signed-off-by: Will Deacon <will@kernel.org>
>Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
Queued this and the ones for older kernels. In general, if it's just a
cherrypick, please just list commit ids as it makes our lives much
easier :)
--
Thanks,
Sasha
next prev parent reply other threads:[~2023-10-06 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 19:34 [PATCH 6.5] iommu/arm-smmu-v3: Avoid constructing invalid range commands Easwar Hariharan
2023-10-06 13:52 ` Sasha Levin [this message]
2023-10-10 16:32 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSARLoAx_mPkrG8f@sashalap \
--to=sashal@kernel.org \
--cc=eahariha@linux.microsoft.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
--cc=zhurui3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox