Possibly broken Linux 5.10.198 backport spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

Possibly broken Linux 5.10.198 backport spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

[Marek Vasut]

Linux 5.10.198 commit
2cdec9c13f81 ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in 
zynqmp_qspi_probe")

looks very different compared to matching upstream commit:
a21fbc42807b ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in 
zynqmp_qspi_probe")

The Linux 5.10.198 change breaks a platform for me and it really looks 
like an incorrect backport.

Dinghao, can you have a look ?

Thank you

Re: Possibly broken Linux 5.10.198 backport spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

On Thu, Oct 12, 2023 at 06:39:10PM +0200, Marek Vasut wrote:
> Linux 5.10.198 commit
> 2cdec9c13f81 ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in
> zynqmp_qspi_probe")
> 
> looks very different compared to matching upstream commit:
> a21fbc42807b ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in
> zynqmp_qspi_probe")
> 
> The Linux 5.10.198 change breaks a platform for me and it really looks like
> an incorrect backport.
> 
> Dinghao, can you have a look ?
> 

Thanks for the regression report. I'm adding it to regzbot (as stable-specific
one):

#regzbot ^introduced: 2cdec9c13f81

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Possibly broken Linux 5.10.198 backport spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

[Sasha Levin]

On Fri, Oct 13, 2023 at 12:39:23PM +0700, Bagas Sanjaya wrote:
>On Thu, Oct 12, 2023 at 06:39:10PM +0200, Marek Vasut wrote:
>> Linux 5.10.198 commit
>> 2cdec9c13f81 ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in
>> zynqmp_qspi_probe")
>>
>> looks very different compared to matching upstream commit:
>> a21fbc42807b ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in
>> zynqmp_qspi_probe")
>>
>> The Linux 5.10.198 change breaks a platform for me and it really looks like
>> an incorrect backport.
>>
>> Dinghao, can you have a look ?
>>
>
>Thanks for the regression report. I'm adding it to regzbot (as stable-specific
>one):
>
>#regzbot ^introduced: 2cdec9c13f81

I'm going to revert it from 5.10.

-- 
Thanks,
Sasha

Re: Possibly broken Linux 5.10.198 backport spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

On Sat, Oct 14, 2023 at 12:39:35PM -0400, Sasha Levin wrote:
> On Fri, Oct 13, 2023 at 12:39:23PM +0700, Bagas Sanjaya wrote:
> > On Thu, Oct 12, 2023 at 06:39:10PM +0200, Marek Vasut wrote:
> > > Linux 5.10.198 commit
> > > 2cdec9c13f81 ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in
> > > zynqmp_qspi_probe")
> > > 
> > > looks very different compared to matching upstream commit:
> > > a21fbc42807b ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in
> > > zynqmp_qspi_probe")
> > > 
> > > The Linux 5.10.198 change breaks a platform for me and it really looks like
> > > an incorrect backport.
> > > 
> > > Dinghao, can you have a look ?
> > > 
> > 
> > Thanks for the regression report. I'm adding it to regzbot (as stable-specific
> > one):
> > 
> > #regzbot ^introduced: 2cdec9c13f81
> 
> I'm going to revert it from 5.10.
> 

OK, thanks!

Don't forget to add Link: to this regression report and most importantly,
Fixes: to the culprit commit when reverting.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Possibly broken Linux 5.10.198 backport spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in zynqmp_qspi_probe

[Linux regression tracking #update (Thorsten Leemhuis)]

[TLDR: This mail in primarily relevant for Linux kernel regression
tracking. See link in footer if these mails annoy you.]

On 15.10.23 07:29, Bagas Sanjaya wrote:
> On Sat, Oct 14, 2023 at 12:39:35PM -0400, Sasha Levin wrote:
>> On Fri, Oct 13, 2023 at 12:39:23PM +0700, Bagas Sanjaya wrote:
>>> On Thu, Oct 12, 2023 at 06:39:10PM +0200, Marek Vasut wrote:
>>>> Linux 5.10.198 commit
>>>> 2cdec9c13f81 ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in
>>>> zynqmp_qspi_probe")
>>>>
>>>> looks very different compared to matching upstream commit:
>>>> a21fbc42807b ("spi: spi-zynqmp-gqspi: Fix runtime PM imbalance in
>>>> zynqmp_qspi_probe")
>>>>
>>>> The Linux 5.10.198 change breaks a platform for me and it really looks like
>>>> an incorrect backport.
>>>>
>>>> Dinghao, can you have a look ?
>>>>
>>>
>>> Thanks for the regression report. I'm adding it to regzbot (as stable-specific
>>> one):
>>>
>>> #regzbot ^introduced: 2cdec9c13f81
>>
>> I'm going to revert it from 5.10.
>>
> 
> OK, thanks!
> 
> Don't forget to add Link: to this regression report and most importantly,
> Fixes: to the culprit commit when reverting.

That did not happen, but no big deal:

#regzbot fix: 1ceaf0d3a883bd5f
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.