public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Younes Manton <younes.m@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: Request backport of "perf inject: Fix GEN_ELF_TEXT_OFFSET for jit"
Date: Sat, 14 Oct 2023 12:38:30 -0400	[thread overview]
Message-ID: <ZSrEBsL38S6rXTkX@sashalap> (raw)
In-Reply-To: <CAMVNhxS-6qNfxy8jHrY5EtZASTL9gAvZi=BdTkUA5_5CSQ2Cmg@mail.gmail.com>

On Fri, Oct 13, 2023 at 07:22:02PM -0400, Younes Manton wrote:
>The following commit:
>
>[babd04386b1df8c364cdaa39ac0e54349502e1e5] perf jit: Include program
>header in ELF files
>
>introduced a bug in perf that causes samples to be attributed to the
>wrong instructions in the annotated assembly output of `perf report`
>and `perf annotate`.
>
>The following commit:
>
>[89b15d00527b7825ff19130ed83478e80e3fae99] perf inject: Fix
>GEN_ELF_TEXT_OFFSET for jit
>
>fixes the bug.
>
>Buggy commit is present in 4.19, 5.4, 5.10, and 5.15. The fix is in
>6.1, 6.4, and 6.5. Can it also be backported to at least the 5.x
>kernels, if not 4.19?
>
>The output looks very confusing when parts of the code one expects to
>accumulate ticks don't and other parts that shouldn't be executed at
>all accumulate ticks.
>
>I opened https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2020197
>and was directed here, hopefully I understood the request correctly.
>Thank you.

Queued up, thanks.

-- 
Thanks,
Sasha

      reply	other threads:[~2023-10-14 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 23:22 Request backport of "perf inject: Fix GEN_ELF_TEXT_OFFSET for jit" Younes Manton
2023-10-14 16:38 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSrEBsL38S6rXTkX@sashalap \
    --to=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=younes.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox